From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id NXmvKN2Uh2cv3Q8AWB0awg (envelope-from ) for ; Wed, 15 Jan 2025 05:58:37 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=MTjes5+w; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 960C11E100; Wed, 15 Jan 2025 05:58:37 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=unavailable autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 389891E08E for ; Wed, 15 Jan 2025 05:58:37 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 9D9AD385DDDD for ; Wed, 15 Jan 2025 10:58:36 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9D9AD385DDDD Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=MTjes5+w Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2074.outbound.protection.outlook.com [40.107.223.74]) by sourceware.org (Postfix) with ESMTPS id C08BF385DDC3 for ; Wed, 15 Jan 2025 10:55:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C08BF385DDC3 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=amd.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C08BF385DDC3 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.223.74 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1736938534; cv=pass; b=ix3A8FMLvoAoUQbMpn4iW6MyOuFI16FnAbBmE8saLW/oA3PfsF2/1LkmQECBVztzeenZ7nlfWycMI09/dNHwUtXcv8UVkw8TiiAUg96bvU2J8bnBOGz1YyTbgLScFdAfmuGiWcqOKhBX8Xbe8cWGNxeqIaM4l01KJee50++QAII= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1736938534; c=relaxed/simple; bh=/BGBtq9giwucEXys715x3xr/pkCI3ShggkHdysBG0+4=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=O17Zdn4sV9A9+oT+RGh+Eq9MkcsCGPlBGfKHg4sgd7BdLbmLl2kono9/baZVXqhmAqawbm30zWDpILDbN55LZh0gQoeThmi2SIv1ryvTwp9OWi0aPoGBHTEEFVm/7QUFvq/pQBZlRZ7As1k0kVW2OWDhVoWKaKrGMk9V5GexjA8= ARC-Authentication-Results: i=2; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C08BF385DDC3 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=U+1LWHgC7l/oGq+cq3QHUXVtIOGI0ps1c8lPOiWDJ+t4R0KR0zkzUME0bLdmlZrhp7yA5rslTdPuXmVHBg8PbRy9pkFH/cslaDqh67mh/TeJJOUqrmh1wrXTcYPt6qQ6IJQZUWy01cjy4vLeS/OYosu/qXBvBsxlYY9GOYdJUpz3A5HGlGzwgUyJ5VI7FenZ3u4jSJ3ikQQbWvBndWWFhNoGeH1++tt2tPIwglRM/arKK4WwvC4ahGj79OCzwnFFXaxXuMLWJph6O/7g3+wSm7CBCyjtWef4QT1GbiNwsaa7pBRe0XNHm2WeGj6tvv63nLvhwxec42SxE6X2YKuZjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qqfahzUZzBvJph6RQy60wmBYcTVp1wbQlkv7prR0BCY=; b=vmW5t0mlAvDmVRTudAbkbFQD3zBMjXB4rftz6HPIKoGvu7Zi7dy9REeGaaKjjH1cWzL+iU6dsoUIYYmc7rv8pp8bxdOtEscNmctWTWdwQXTxngwlpd7ufXwPS9DXIRqPFJlUAJ80gMHpPuYpNo4X14iot3Y5hlDfqBYgMphvQphaiVr9YTaXDGCVFzSDjbIPJr7nAZXmYHrotJvVptJ4jh/7dqJHuUpxT5L2E0ilwoH6s0UNBGvEH+pp8DiWkiLXc38dNE6GFfGzAEt6Dpi74fTZA10Q8T1H11Csny6hN1yUda/Fcdhr3pEWHe3JyxYs/VjEQK8CEVLamEYnFIut8Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qqfahzUZzBvJph6RQy60wmBYcTVp1wbQlkv7prR0BCY=; b=MTjes5+wwZybwMJXQx4Vj4BVXrP4vI4KHp9ZqL/Xn6j6KAAGiT/GLMbU2FNuudGRArDF3sowru4GffF+j+jfTD9WHzGtUlZeGDgZ0pwRwYnYtnxwHnHzkqEvQSaGJQqcXhqJ8o9a5zRh0MK4Uq2L7EPDX8ZH2L7w/gWbWCAFLlg= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH3PR12MB9079.namprd12.prod.outlook.com (2603:10b6:610:1a1::9) by PH7PR12MB6000.namprd12.prod.outlook.com (2603:10b6:510:1dc::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8356.13; Wed, 15 Jan 2025 10:55:31 +0000 Received: from CH3PR12MB9079.namprd12.prod.outlook.com ([fe80::8c67:8cec:7c4a:ccaa]) by CH3PR12MB9079.namprd12.prod.outlook.com ([fe80::8c67:8cec:7c4a:ccaa%7]) with mapi id 15.20.8335.017; Wed, 15 Jan 2025 10:55:31 +0000 Message-ID: Date: Wed, 15 Jan 2025 10:55:26 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] gdb/amd-dbgapi: use gdb::unordered_map To: simon.marchi@polymtl.ca, gdb-patches@sourceware.org Cc: Simon Marchi References: <20250114191818.2393132-1-simon.marchi@polymtl.ca> <20250114191818.2393132-2-simon.marchi@polymtl.ca> Content-Language: en-US From: Lancelot SIX In-Reply-To: <20250114191818.2393132-2-simon.marchi@polymtl.ca> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0173.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a0::15) To CH3PR12MB9079.namprd12.prod.outlook.com (2603:10b6:610:1a1::9) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH3PR12MB9079:EE_|PH7PR12MB6000:EE_ X-MS-Office365-Filtering-Correlation-Id: b209d861-cd69-46ac-c051-08dd35532112 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|366016|7053199007; X-Microsoft-Antispam-Message-Info: =?utf-8?B?WGZFc0padmxKOVJsTEJOQ01tMVl4b251RlVBeSt1WE1uQnpJR3BtTXJoem5z?= =?utf-8?B?dXdIbzlZQ3UzM0ZQSDlTQ3AvdEtDRmV2RXZabzRIOHdzbUN6TkFaSFRsYXF2?= =?utf-8?B?azFvbFlBVVVOVXZpamhyVm1MSHZJQWhNSU1SZGRMTXdlR0hpS29nOE4rUVhO?= =?utf-8?B?R1RHYk00QWwwSzhsWVNtMFJQTm9PQi9ZR2NkaUxHWUhsVUlVVE5GdmJsajFL?= =?utf-8?B?UHZYZE41SXNRbTVneDEwUmF4dmNYdEpCc3RTcTQzNXdEdWNBaXBHSHdaTjJZ?= =?utf-8?B?Qm9NMnZSVmlBeHZMcDA2bStzYm1nWk5YNXlMT0MwNVJ5ZTZTdUlWYmVSTnpp?= =?utf-8?B?aGRXak1XSUpKSlUzRzJCdmVTMWhzSU9NQ2l2OU5qYkc4UUVSV0FQOEJhWDF5?= =?utf-8?B?VWZxVGFsV05oMlNkdmg4MS83RTR1cmFTYkZVZnZLQkhZRmFiQkVsWlFSK3FT?= =?utf-8?B?eG9BaGJlc2JpUURvbWxuWG9tc2FES09rdDlDUlowQ0hZdWxNZDlLY1RHMUVx?= =?utf-8?B?SjQwMm90WlZxMmc4VDdxbkJIemxVa211eTluRmYzdkNzOGswU3NZTzEyTnMw?= =?utf-8?B?R0ZEUHBPNm51V0VNdnI0Y0dGS3N0aG9MTTU2bU1vZkp5Q0xLbEdZMmhCZ3ZF?= =?utf-8?B?THhjY0lxMmV5Y2RzVytobTJCUU5HYkNjdDVYcmo2TzFiRUtBNy9FODU2eHVj?= =?utf-8?B?UVAvNU45dWx5dEZ0Vi9hcmxEWHBnVC82Qy9QTFBPL2VtK0hOQ29kY0V0amZm?= =?utf-8?B?K2g4RDVvbSs2RW00YzEzK0Y3NU8rcjBNK3EwSFVkbzFCYTZ5NVNhbXpNVGRO?= =?utf-8?B?T1VhOFA1QklDV0FCZ3JmUkp3ZUUraEJrSnhBNG5FUzBGNldiZ3lUVEVoZTV0?= =?utf-8?B?OHVTRWY2N3dwNGhKOTNrcDVmdmphQ216WW1UazFQMVVieklxZTBRTG9MK09H?= =?utf-8?B?Ri80VmZBMmJya0x2eEdSQ3d5RDA2aVJpdnByOUlBaWQ2Tjh6ZWNBdjl5YWtE?= =?utf-8?B?NWxkOW1GbEsrWTliTEczL3FGYlJ2Ti9peEUrMmJGY3J0SjhOc2JvdzkrZlo5?= =?utf-8?B?TURxZ0dCdXBPWkhtenlNSW5RcjRKam5Xb3pGU2xUczVSZVRxZ0RxYW9JQW5w?= =?utf-8?B?YmhrZmpBQnNBWkpwUzMwd25mU2Q5Ny9UQ2dKNTFDcDVjbUEwTzlIT3I2U1JR?= =?utf-8?B?K2RwQXRJeUk4KzNkTGNJQUFLZEVpT1BsK2cxV2VLOExzSVJDOU5oeDdiODht?= =?utf-8?B?TjU1T3UyL2tQMldCSXRZcDB6QVZDUHltMGFsRE1KR1VyM2RVWE1ReEZIcnRO?= =?utf-8?B?WlFZYVRWTGUrem8xN3p2dmh5anVPVFRtRGJja0N6UnJNTHBYbHhtNDgvOXFr?= =?utf-8?B?KzNQYjZHL1puR0w0VXNSYXVpN1o2S09QYXVWdWlkZ29PbEZGNmc4ZGpPdzhJ?= =?utf-8?B?NXkrejhieXVOUkZJdHhIL1gwWEh3ME14aVpYbHNnWWQrVHJXL1FjWFdSZUFj?= =?utf-8?B?bGgvWUR6WDVVc1l3Z0t6bml0blRHamxvUmlqQTlnS0ViaFV6TWRkMkgxVDli?= =?utf-8?B?Vk5OaDNtNXdHMm9DZlpsdVNma0xzei9uTlA5VXZOZkJFT2trZW1HQ2k0NjNB?= =?utf-8?B?bmZWakVMSnNrajhBejZ3VTNCVmhXSGhRNllNUkk3WmtEU1VuSFlaT21iWmtj?= =?utf-8?B?ejRqN1RLQ2d4OW9MYnhRbnpCUHI5bmVaUVIwdkVabHFlZWw2YWdadEtidFR4?= =?utf-8?B?QWVuYXdBNlZJczIrQ2Z0YXBQd0VNdGtoMkhWSFBwYUdnYVErQ1N4WTdTL21s?= =?utf-8?B?QS9rNk9maUlQSUx5ZE9qNmNWTUJOMjg1S2hmZjFwQmhCRHBFSVBlTWR1M3ZR?= =?utf-8?Q?ym/HNszxzC0hy?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH3PR12MB9079.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(376014)(366016)(7053199007); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VzhPWFRaaDlKTGFiZnBFK05ON1BQMElmeCs5Vk16bFM2K2FnNUZCSEx3Z1Ji?= =?utf-8?B?MGczelFQKzlmNmZQY1paaXVoUnpLQ08yQVJqbXdiczQ3S29OdjMvenZrallX?= =?utf-8?B?a0hLM0NCdWk5a250eFRkcXgxZS80UnFRdzVaVzdrU0o2bmRrVUg2bVFTYTJm?= =?utf-8?B?NWFJcFN4VmpmMVNNRTQvNVdFTjhCcmNhVUJTRWJMaEdsV1ZnVVhsMGZiS3Rs?= =?utf-8?B?bWFvcHpXY2w1Mkd4ajJEbFdxMHduKzBHb0hGcmFKTm1hWmdyT29kdlpVVEZy?= =?utf-8?B?Qmt5U29JOGFibXRtbkNHQjBoWmhjWUJsR2h1bHhMa2ZzcnhhUzFVd1RVZnN1?= =?utf-8?B?cCtYeHh2UVVGVDVGdGlOOTd3bWxaSGRKK29IaVZuSU5aaTNaRSsrdEZsMHlL?= =?utf-8?B?YnA5dWZxaGZ6cUUxVUhEOFpyeGZBVTc4TnFOR2QyeUxWRmVUdFgwK2FEMFB1?= =?utf-8?B?bWxaYnBFOXZOdXNUbmFiMHFHNmZ4ZzN4WVA1bUxCM0s5VHhEV2ttZ0pMMHIw?= =?utf-8?B?UjhIcGlhTk5kWEl0TW8xZTdTMlRuWE9paXc3ellPb3VTdFdGQkRDbEVIR0xQ?= =?utf-8?B?Mk4vcmFpNmJXWjhtU3dzNG1YdU1JRHZDd25Na1Q3b2xIcVVNY2JNaUQ0YndD?= =?utf-8?B?VmNuZXBhdjk0L3BBM0xMK3VzbXRuOHZrbnVVYzRRZm9Db1BIdzlEL3lsM1d3?= =?utf-8?B?M2IyZHVsdjJFMEFidkRQTTg3Y2REd25wcit3TjNFMUpXMVFsUlpGbDFNME4x?= =?utf-8?B?eG0rNnBWYVVqTksydVArbFFqRCtvVFhvM1RBM2JpQ0VEdnVCWUxmVHV5WHNX?= =?utf-8?B?MnNUa2ZOVnFDbDVoV2NvVzlXL2JlRzRrbWJBRzdmYUVrQjRHRE40ZDhSSGhw?= =?utf-8?B?NmN2L0xuZjdGN2Y4dWFVV2VqUW1PbjR2amVpNUhscFQ2bkcxK0x3NllCZ0J3?= =?utf-8?B?Smxkc080WkwvdXF3QVlVOEJicW5PMmtMaTdjYlNnSjNmUVlwNlEyTGpZd1c4?= =?utf-8?B?a0h5OE96ajUvdk10MDliWldiR2VndTFwZ2NGaklVd1g1QkxBcUM4aUFZU1hh?= =?utf-8?B?WE04dytKamZUTFMveS94THp6THkwRWZ4bUlHZjZkdHg3dHRUNzlHcmVSRzhj?= =?utf-8?B?SExpREF3Yjk2czg3cUlhdVMyVCt3TEpUNEphUW5iTXZzdktjNnkvbVZlU0pt?= =?utf-8?B?RmQrbGZiN2txb3pDV2ZSWDJVc0RPb3ZSOFhUNERGeGxieHYxMUhUQURrWTBV?= =?utf-8?B?QXJ5ODREdzZodUpnSE1md0Z2ODhGUDRCb2NBTitIR1hnT25LaDhFOU5kS0VP?= =?utf-8?B?RTFJTlBjOEhTd2w5NXlWMHhxVExiUFdrYkl5eUJnTVBSYmszdmdBclE4RGZa?= =?utf-8?B?bnFqTjNhYXFnRndhZkxzUkxsdHF6bFNhbXpMSGRkTGdvVEZxZXBKR0pNdC9L?= =?utf-8?B?UXNDVHBVZzJRU2lRSWtyQ2U0eExmSGpMTWg4SW9ZNjBJUEwvL0hqMllvNEhj?= =?utf-8?B?WktGTVFJUEFLK3RwWGcvVzRiQUlYUmtsQUN2TGtNNStOd0dydlhOTm5aaVVJ?= =?utf-8?B?czBmTllOb3laYVZFcG01dk1vNGJiYXpxMTkxSDFyd2x2RGt1VTdoc3BwTmFE?= =?utf-8?B?cHJrK1NRblh1OGYzMXd2QjZjQzNqZUdlOEpMeld3OE1URzhwaHRMaHFoZnZI?= =?utf-8?B?aXlLUGxwZXBDSlpFSmJ2YmtkeHB3NVB4M0tUbE5Pa01tczJHOGJmVkpINkdw?= =?utf-8?B?Rk03VlNtd1hYVDM2S2N5MFc2Si9PcDRLbGZWZ0tDWTMxa2hqQTdwN1NkU2Mz?= =?utf-8?B?UEVRSFFweTZ4eUJWbDFUa0R3c1I2a1VRWlgxZlBUME4rc3ZTcmZvL1VSaS9s?= =?utf-8?B?bjFjbTZpQ3ZscEkxNmQvWWVRU1BnUHNtR1Zvb3JrWCtYTGRzWGExd1JnZUVR?= =?utf-8?B?WHNHWllLdHVadnpqcTkxNTdDekM0b3pmNlpFVGVZUFZabHZPWEJuYmxaWUFY?= =?utf-8?B?cXFVQitFRXhiR2dyNEhkdFZFY1NDS2p2MHVXbmI2M0J6MWpZVURkRjBsNyt0?= =?utf-8?B?akVPQUZUczJ3dDBFMXFrNy9xZEErYmhrSDZNNi9ZVWtocEpnMCs0aFE0dkpM?= =?utf-8?Q?R/w9OoIUl2YCWu7FZMRDNecb3?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: b209d861-cd69-46ac-c051-08dd35532112 X-MS-Exchange-CrossTenant-AuthSource: CH3PR12MB9079.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jan 2025 10:55:31.2409 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ahhBb4HZPX+IYT1qqZY6V3QDsaRnnWE1ABy2YU/WdtVxaoR3wtErFZkOCwQLXcOj7F5aNELA5r3E2JuEETdz+w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 14/01/2025 19:16, simon.marchi@polymtl.ca wrote: > Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. > > > From: Simon Marchi > > Since we have gdb::unordered_map, swap std::unordered_map for that. > Hi, That looks good to me, thanks. Since it only touches the amdgpu backend, Approved-By: Lancelot Six (amdgpu) Best, Lancelot. > Change-Id: If2ef652fe18c1a440a25cff6131d29e37091bdbe > --- > gdb/amd-dbgapi-target.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/gdb/amd-dbgapi-target.c b/gdb/amd-dbgapi-target.c > index 2bb79acd76f0..153a35f788ed 100644 > --- a/gdb/amd-dbgapi-target.c > +++ b/gdb/amd-dbgapi-target.c > @@ -24,6 +24,7 @@ > #include "cli/cli-cmds.h" > #include "cli/cli-decode.h" > #include "cli/cli-style.h" > +#include "gdbsupport/unordered_map.h" > #include "inf-loop.h" > #include "inferior.h" > #include "objfiles.h" > @@ -207,7 +208,7 @@ struct amd_dbgapi_inferior_info > bool enabled = false; > } precise_memory; > > - std::unordered_map + gdb::unordered_map struct breakpoint *> > breakpoint_map; > > @@ -221,7 +222,7 @@ struct amd_dbgapi_inferior_info > > wave_info objects are added when we first see the wave, and > removed from a thread_deleted observer. */ > - std::unordered_map > + gdb::unordered_map > wave_info_map; > }; > > -- > 2.47.1 >