Re: [Prec/RFA] fix build error of prec in cygwin

[Hui Zhu <teawater@gmail.com>]

Hi Christopher,

On Thu, May 21, 2009 at 23:26, Christopher Faylor
<cgf-use-the-mailinglist-please@sourceware.org> wrote:
> On Thu, May 21, 2009 at 10:38:58AM +0800, Hui Zhu wrote:
>>Ping
>
> You are aware that it took you about seven days to respond to one of my
> messages right?
>

Sorry for that. To get a cygwin environment is very hard thing for a
linux guy.  And I found that cygwin cannot work with wine.

> I was confused by the fact that you didn't seem to be using CVS to
> generate your diffs and, on closer inspection, I see that there are
> multiple places where coercion is used inappropriately when the format
> specifier should just have matched the parameter.

Sorry for my poor english.  I got patch with quilt.

>
> Some of your changes are now using "%u" with "(int) sizeof" (which is
> wrong) and some of the existing code is just using "(int) sizeof" with
> "%d" which is also wrong.
>
> So, in other words, the file was already not quite "right" and I don't
> think your changes are getting it much closer to "right".
>

Thanks for you help me review my patch.  Could you give me some help with it?
Actually, try something with cygwin still a very hard thing for me.  I
just can use it in a notebook of other guy.  And I had return it.
Maybe you can make a patch for this bug.  That will be very great for me.

> I was not implying that your changes didn't fix compiler errors.  I was
> saying that I didn't think they were the correct way to fix the errors.
> However, since I am apparently the only person who cares about this
> stuff, and it doesn't seem like my point is getting across, I think I'll
> just shut up now.  Other, global maintainers have said that they were ok
> with your changes so I'm not going to object even if they don't make
> sense to me.

Please do not misunderstand us.  I just get a mail from Pierre who
report this bug.  And this mail just say this patch test with cygwin
is OK.  Because I let Pierre help me test the patch with cygwin.  That
is all.


Thanks,
Hui