From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2586 invoked by alias); 21 May 2009 16:43:16 -0000 Received: (qmail 2571 invoked by uid 22791); 21 May 2009 16:43:15 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail-px0-f199.google.com (HELO mail-px0-f199.google.com) (209.85.216.199) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 21 May 2009 16:43:09 +0000 Received: by pxi37 with SMTP id 37so1303760pxi.12 for ; Thu, 21 May 2009 09:43:07 -0700 (PDT) MIME-Version: 1.0 Received: by 10.110.95.3 with SMTP id s3mr78048tib.37.1242924187077; Thu, 21 May 2009 09:43:07 -0700 (PDT) In-Reply-To: <20090521152621.GA27524@ednor.casa.cgf.cx> References: <20090510174809.GA25909@ednor.casa.cgf.cx> <20090510235109.GD25909@ednor.casa.cgf.cx> <20090518153510.GA23052@ednor.casa.cgf.cx> <20090521152621.GA27524@ednor.casa.cgf.cx> Date: Thu, 21 May 2009 16:43:00 -0000 Message-ID: Subject: Re: [Prec/RFA] fix build error of prec in cygwin From: Hui Zhu To: gdb-patches ml , Christopher Faylor Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-05/txt/msg00463.txt.bz2 Hi Christopher, On Thu, May 21, 2009 at 23:26, Christopher Faylor wrote: > On Thu, May 21, 2009 at 10:38:58AM +0800, Hui Zhu wrote: >>Ping > > You are aware that it took you about seven days to respond to one of my > messages right? > Sorry for that. To get a cygwin environment is very hard thing for a linux guy. And I found that cygwin cannot work with wine. > I was confused by the fact that you didn't seem to be using CVS to > generate your diffs and, on closer inspection, I see that there are > multiple places where coercion is used inappropriately when the format > specifier should just have matched the parameter. Sorry for my poor english. I got patch with quilt. > > Some of your changes are now using "%u" with "(int) sizeof" (which is > wrong) and some of the existing code is just using "(int) sizeof" with > "%d" which is also wrong. > > So, in other words, the file was already not quite "right" and I don't > think your changes are getting it much closer to "right". > Thanks for you help me review my patch. Could you give me some help with i= t? Actually, try something with cygwin still a very hard thing for me. I just can use it in a notebook of other guy. And I had return it. Maybe you can make a patch for this bug. That will be very great for me. > I was not implying that your changes didn't fix compiler errors. =A0I was > saying that I didn't think they were the correct way to fix the errors. > However, since I am apparently the only person who cares about this > stuff, and it doesn't seem like my point is getting across, I think I'll > just shut up now. =A0Other, global maintainers have said that they were ok > with your changes so I'm not going to object even if they don't make > sense to me. Please do not misunderstand us. I just get a mail from Pierre who report this bug. And this mail just say this patch test with cygwin is OK. Because I let Pierre help me test the patch with cygwin. That is all. Thanks, Hui