Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Christopher Faylor <cgf-use-the-mailinglist-please@sourceware.org>
To: gdb-patches ml <gdb-patches@sourceware.org>,
		Hui Zhu <teawater@gmail.com>
Subject: Re: [Prec/RFA] fix build error of prec in cygwin
Date: Fri, 22 May 2009 00:46:00 -0000	[thread overview]
Message-ID: <20090522004623.GI28993@ednor.casa.cgf.cx> (raw)
In-Reply-To: <daef60380905211614u2118b66did7cf783ae1b41bb0@mail.gmail.com>

On Fri, May 22, 2009 at 07:14:48AM +0800, Hui Zhu wrote:
>On Fri, May 22, 2009 at 01:38, Christopher Faylor  wrote:
>> On Fri, May 22, 2009 at 12:43:07AM +0800, Hui Zhu wrote:
>>>Thanks for you help me review my patch. ?Could you give me some help
>>>with it? ?Actually, try something with cygwin still a very hard thing
>>>for me. ?I just can use it in a notebook of other guy. ?And I had
>>>return it. ?Maybe you can make a patch for this bug. ?That will be very
>>>great for me.
>>
>>I don't see why this has anything to do with Cygwin.  ?We're talking
>>about general principles here.  If you know C, which you obviously do,
>>then I don't really understand why this needs a lot of explanation.
>>Look at the places where you're using coercion with a format string and
>>just use the right format specifier instead.
>
>Because the patch must be work OK with cygwin.  Even if for the format.
>I think you must have a lot of good idea with it.  We need your help.
>That is very great for me.  Thanks a lot.

No need to thank me yet.  I'll be happy to review your change when you
make the simple changes that I requested.  You can hold off thanking me
until then.

cgf


  reply	other threads:[~2009-05-22  0:46 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-10 17:31 Hui Zhu
2009-05-10 17:48 ` Christopher Faylor
2009-05-10 18:07   ` Hui Zhu
2009-05-10 23:51     ` Christopher Faylor
2009-05-18  8:43       ` Hui Zhu
2009-05-18 15:35         ` Christopher Faylor
2009-05-19  2:34           ` Hui Zhu
2009-05-21  2:39             ` Hui Zhu
2009-05-21 15:26               ` Christopher Faylor
2009-05-21 15:35                 ` Pedro Alves
2009-05-21 17:35                   ` Christopher Faylor
2009-05-21 16:43                 ` Hui Zhu
2009-05-21 17:38                   ` Christopher Faylor
2009-05-21 23:14                     ` Hui Zhu
2009-05-22  0:46                       ` Christopher Faylor [this message]
2009-05-22  2:12                         ` Hui Zhu
2009-05-22  4:13                           ` Christopher Faylor
2009-05-22  5:53                             ` Hui Zhu
2009-05-22  6:05                             ` Joel Brobecker
2009-05-22  6:56                               ` Eli Zaretskii
2009-05-22  8:42                                 ` Hui Zhu
2009-05-22  9:37                                   ` Eli Zaretskii
2009-05-22 10:11                                   ` Jie Zhang
2009-05-22  9:06                                 ` Hui Zhu
2009-05-22  9:30                                   ` Eli Zaretskii
2009-05-22 14:11                                     ` Hui Zhu
2009-05-22 17:02                               ` Christopher Faylor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090522004623.GI28993@ednor.casa.cgf.cx \
    --to=cgf-use-the-mailinglist-please@sourceware.org \
    --cc=gdb-patches@sourceware.org \
    --cc=teawater@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox