Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Christopher Faylor <cgf-use-the-mailinglist-please@sourceware.org>
To: gdb-patches ml <gdb-patches@sourceware.org>,
		Hui Zhu <teawater@gmail.com>
Subject: Re: [Prec/RFA] fix build error of prec in cygwin
Date: Mon, 18 May 2009 15:35:00 -0000	[thread overview]
Message-ID: <20090518153510.GA23052@ednor.casa.cgf.cx> (raw)
In-Reply-To: <daef60380905180143l63bcc007n9821638179ef84ec@mail.gmail.com>

On Mon, May 18, 2009 at 04:43:36PM +0800, Hui Zhu wrote:
>On Mon, May 11, 2009 at 07:51, Christopher Faylor wrote:
>> So wouldn't that indicate that your format specifier is wrong and should
>> be "%u" rather than "%d"? ?Coercion is something that should be avoided
>> unless it is absolutely necessary.
>>
>
>I changed it.

It looks like this diff is against your previous version rather than CVS
so it is confusing.  But, it still seems like you're still coercing
using (int)len but now you're using %u.  So, it looks like you've just
swapped the problem.

cgf


  reply	other threads:[~2009-05-18 15:35 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-10 17:31 Hui Zhu
2009-05-10 17:48 ` Christopher Faylor
2009-05-10 18:07   ` Hui Zhu
2009-05-10 23:51     ` Christopher Faylor
2009-05-18  8:43       ` Hui Zhu
2009-05-18 15:35         ` Christopher Faylor [this message]
2009-05-19  2:34           ` Hui Zhu
2009-05-21  2:39             ` Hui Zhu
2009-05-21 15:26               ` Christopher Faylor
2009-05-21 15:35                 ` Pedro Alves
2009-05-21 17:35                   ` Christopher Faylor
2009-05-21 16:43                 ` Hui Zhu
2009-05-21 17:38                   ` Christopher Faylor
2009-05-21 23:14                     ` Hui Zhu
2009-05-22  0:46                       ` Christopher Faylor
2009-05-22  2:12                         ` Hui Zhu
2009-05-22  4:13                           ` Christopher Faylor
2009-05-22  5:53                             ` Hui Zhu
2009-05-22  6:05                             ` Joel Brobecker
2009-05-22  6:56                               ` Eli Zaretskii
2009-05-22  8:42                                 ` Hui Zhu
2009-05-22  9:37                                   ` Eli Zaretskii
2009-05-22 10:11                                   ` Jie Zhang
2009-05-22  9:06                                 ` Hui Zhu
2009-05-22  9:30                                   ` Eli Zaretskii
2009-05-22 14:11                                     ` Hui Zhu
2009-05-22 17:02                               ` Christopher Faylor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090518153510.GA23052@ednor.casa.cgf.cx \
    --to=cgf-use-the-mailinglist-please@sourceware.org \
    --cc=gdb-patches@sourceware.org \
    --cc=teawater@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox