From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11823 invoked by alias); 18 May 2009 15:35:30 -0000 Received: (qmail 11815 invoked by uid 22791); 18 May 2009 15:35:29 -0000 X-Spam-Check-By: sourceware.org Received: from pool-173-48-46-134.bstnma.fios.verizon.net (HELO cgf.cx) (173.48.46.134) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 18 May 2009 15:35:22 +0000 Received: from ednor.cgf.cx (ednor.casa.cgf.cx [192.168.187.5]) by cgf.cx (Postfix) with ESMTP id 428BF13C023; Mon, 18 May 2009 11:35:11 -0400 (EDT) Received: by ednor.cgf.cx (Postfix, from userid 201) id 9AFA81D78E; Mon, 18 May 2009 11:35:11 -0400 (EDT) Date: Mon, 18 May 2009 15:35:00 -0000 From: Christopher Faylor To: gdb-patches ml , Hui Zhu Subject: Re: [Prec/RFA] fix build error of prec in cygwin Message-ID: <20090518153510.GA23052@ednor.casa.cgf.cx> Mail-Followup-To: gdb-patches ml , Hui Zhu References: <20090510174809.GA25909@ednor.casa.cgf.cx> <20090510235109.GD25909@ednor.casa.cgf.cx> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.16 (2007-06-09) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-05/txt/msg00364.txt.bz2 On Mon, May 18, 2009 at 04:43:36PM +0800, Hui Zhu wrote: >On Mon, May 11, 2009 at 07:51, Christopher Faylor wrote: >> So wouldn't that indicate that your format specifier is wrong and should >> be "%u" rather than "%d"? ?Coercion is something that should be avoided >> unless it is absolutely necessary. >> > >I changed it. It looks like this diff is against your previous version rather than CVS so it is confusing. But, it still seems like you're still coercing using (int)len but now you're using %u. So, it looks like you've just swapped the problem. cgf