From: Tom de Vries <tdevries@suse.de>
To: Tom Tromey <tom@tromey.com>, Kevin Buettner <kevinb@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH, gdb/exp] Handle DW_OP_GNU_variable_value refs to abstract dies
Date: Thu, 06 Sep 2018 06:40:00 -0000 [thread overview]
Message-ID: <d491ca02-58e0-b612-f169-193a57a1b0cd@suse.de> (raw)
In-Reply-To: <87sh2nwaon.fsf@tromey.com>
On 09/06/2018 05:45 AM, Tom Tromey wrote:
>>>>>> "Kevin" == Kevin Buettner <kevinb@redhat.com> writes:
>
> Kevin> Is there a good reason to use VEC instead of std::vector? I know that
> Kevin> there have been a number of patches which have been replacing VEC
> Kevin> with std:vector. So, unless there's a compelling reason to use VEC,
> Kevin> we might as well use std:vector here and save someone else the effort
> Kevin> of changing this use of VEC later on.
>
> Thanks for this note. One of my gdb c++-ification/cleanup goals is to
> get rid of VEC.
It would be nice if the sources reflected that fact.
F.i., we could move the contents from vec.{c,h} to vec-deprecated.{c.h}
and include the new files in vec.{c,h}, and add a note there why they're
deprecated.
I can prepare a patch implementing this or another approach, if there
are better suggestions.
Thanks,
- Tom
next prev parent reply other threads:[~2018-09-06 6:40 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-03 4:04 [PATCH 0/3] Add support for DW_OP_GNU_variable_value Kevin Buettner
2018-08-03 4:18 ` [PATCH 1/3] " Kevin Buettner
2018-08-03 18:36 ` Tom Tromey
2018-08-18 20:32 ` Kevin Buettner
2018-08-22 15:35 ` Tom de Vries
2018-08-23 21:12 ` Kevin Buettner
2018-08-24 13:09 ` [RFC, gdb/exp] Handle DW_OP_GNU_variable_value refs to abstract dies Tom de Vries
2018-08-24 13:18 ` Richard Biener
2018-09-04 10:17 ` [PATCH, " Tom de Vries
2018-09-04 13:06 ` Tom de Vries
2018-09-04 21:54 ` Kevin Buettner
2018-09-05 10:53 ` Tom de Vries
2018-09-06 3:46 ` Tom Tromey
2018-09-06 6:40 ` Tom de Vries [this message]
2018-09-06 13:11 ` Tom Tromey
2018-08-03 18:43 ` [PATCH 1/3] Add support for DW_OP_GNU_variable_value Tom Tromey
2018-08-03 4:19 ` [PATCH 2/3] Add support of DW_OP_GNU_variable_value to DWARF assembler Kevin Buettner
2018-08-03 18:37 ` Tom Tromey
2018-08-18 20:32 ` Kevin Buettner
2018-08-03 4:22 ` [PATCH 3/3] Test case for DW_OP_GNU_variable_value Kevin Buettner
2018-08-03 18:40 ` Tom Tromey
2018-08-18 20:32 ` Kevin Buettner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d491ca02-58e0-b612-f169-193a57a1b0cd@suse.de \
--to=tdevries@suse.de \
--cc=gdb-patches@sourceware.org \
--cc=kevinb@redhat.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox