From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 73573 invoked by alias); 6 Sep 2018 06:40:35 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 73515 invoked by uid 89); 6 Sep 2018 06:40:34 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:952 X-HELO: mx1.suse.de Received: from mx2.suse.de (HELO mx1.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 06 Sep 2018 06:40:33 +0000 Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 049CAADCC; Thu, 6 Sep 2018 06:40:30 +0000 (UTC) Subject: Re: [PATCH, gdb/exp] Handle DW_OP_GNU_variable_value refs to abstract dies To: Tom Tromey , Kevin Buettner Cc: gdb-patches@sourceware.org References: <20180802210405.5c04ca7a@pinnacle.lan> <20180802211754.40a529c2@pinnacle.lan> <87o9ej1emk.fsf@tromey.com> <20180818133158.7e5b4dcb@pinnacle.lan> <93529546-71b0-4268-880a-79b00062ecd2@suse.de> <20180823141240.577345e0@pinnacle.lan> <982919b5-93ba-3840-5839-6accc904b459@suse.de> <5e6ac298-bf8f-6957-984a-67bb58b62be9@suse.de> <95697ec8-30e2-acaf-60fd-e46524f88e72@suse.de> <20180904145449.2cf6a099@pinnacle.lan> <87sh2nwaon.fsf@tromey.com> From: Tom de Vries Message-ID: Date: Thu, 06 Sep 2018 06:40:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <87sh2nwaon.fsf@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2018-09/txt/msg00088.txt.bz2 On 09/06/2018 05:45 AM, Tom Tromey wrote: >>>>>> "Kevin" == Kevin Buettner writes: > > Kevin> Is there a good reason to use VEC instead of std::vector? I know that > Kevin> there have been a number of patches which have been replacing VEC > Kevin> with std:vector. So, unless there's a compelling reason to use VEC, > Kevin> we might as well use std:vector here and save someone else the effort > Kevin> of changing this use of VEC later on. > > Thanks for this note. One of my gdb c++-ification/cleanup goals is to > get rid of VEC. It would be nice if the sources reflected that fact. F.i., we could move the contents from vec.{c,h} to vec-deprecated.{c.h} and include the new files in vec.{c,h}, and add a note there why they're deprecated. I can prepare a patch implementing this or another approach, if there are better suggestions. Thanks, - Tom