From: Tom Tromey <tom@tromey.com>
To: Kevin Buettner <kevinb@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 1/3] Add support for DW_OP_GNU_variable_value
Date: Fri, 03 Aug 2018 18:43:00 -0000 [thread overview]
Message-ID: <87bmaj1ec4.fsf@tromey.com> (raw)
In-Reply-To: <20180802211754.40a529c2@pinnacle.lan> (Kevin Buettner's message of "Thu, 2 Aug 2018 21:17:54 -0700")
>>>>> "Kevin" == Kevin Buettner <kevinb@redhat.com> writes:
I forgot a note earlier...
Kevin> + /* Note: Things still work when the following test is removed. This
Kevin> + test and error is here to conform to the proposed specification. */
Kevin> + if (!is_scalar_type (die_type) || TYPE_CODE (die_type) == TYPE_CODE_VOID)
Kevin> + error (_("Type of DW_OP_GNU_variable_value DIE must be an integer or pointer."));
I suspect is_scalar_type isn't what you want here.
Maybe instead either "is_integral_type || TYPE_CODE == TYPE_CODE_PTR",
or just checking for TYPE_CODE_PTR and TYPE_CODE_INT (since, bizarrely
to me at least, is_integral_type includes range types).
Tom
next prev parent reply other threads:[~2018-08-03 18:43 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-03 4:04 [PATCH 0/3] " Kevin Buettner
2018-08-03 4:18 ` [PATCH 1/3] " Kevin Buettner
2018-08-03 18:36 ` Tom Tromey
2018-08-18 20:32 ` Kevin Buettner
2018-08-22 15:35 ` Tom de Vries
2018-08-23 21:12 ` Kevin Buettner
2018-08-24 13:09 ` [RFC, gdb/exp] Handle DW_OP_GNU_variable_value refs to abstract dies Tom de Vries
2018-08-24 13:18 ` Richard Biener
2018-09-04 10:17 ` [PATCH, " Tom de Vries
2018-09-04 13:06 ` Tom de Vries
2018-09-04 21:54 ` Kevin Buettner
2018-09-05 10:53 ` Tom de Vries
2018-09-06 3:46 ` Tom Tromey
2018-09-06 6:40 ` Tom de Vries
2018-09-06 13:11 ` Tom Tromey
2018-08-03 18:43 ` Tom Tromey [this message]
2018-08-03 4:19 ` [PATCH 2/3] Add support of DW_OP_GNU_variable_value to DWARF assembler Kevin Buettner
2018-08-03 18:37 ` Tom Tromey
2018-08-18 20:32 ` Kevin Buettner
2018-08-03 4:22 ` [PATCH 3/3] Test case for DW_OP_GNU_variable_value Kevin Buettner
2018-08-03 18:40 ` Tom Tromey
2018-08-18 20:32 ` Kevin Buettner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bmaj1ec4.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=kevinb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox