From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4630 invoked by alias); 3 Aug 2018 18:43:38 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 4615 invoked by uid 89); 3 Aug 2018 18:43:37 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gateway20.websitewelcome.com Received: from gateway20.websitewelcome.com (HELO gateway20.websitewelcome.com) (192.185.63.14) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 03 Aug 2018 18:43:36 +0000 Received: from cm15.websitewelcome.com (cm15.websitewelcome.com [100.42.49.9]) by gateway20.websitewelcome.com (Postfix) with ESMTP id 007AA400D920F for ; Fri, 3 Aug 2018 13:43:34 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id lf2Kfgd7UbXuJlf2jf6Mfk; Fri, 03 Aug 2018 13:43:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=amPwI5NCf5KNChUcS1IthBJ4sixtjKMYc0lKtPD3bL4=; b=yk4R4Q5uM4h56kUAQWBeQbdlOj HUDeC6vG7I0q5jUFe7yMA/4tjc+oZPDC+rLau6d66WnRziIXihlGU8P30qjbL6Q50TLLX6enki4vW RfwHxz/iMSpWhtdPgXxPPqJwA; Received: from 75-166-85-72.hlrn.qwest.net ([75.166.85.72]:35394 helo=pokyo) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1flf2K-001iGC-IG; Fri, 03 Aug 2018 13:42:52 -0500 From: Tom Tromey To: Kevin Buettner Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 1/3] Add support for DW_OP_GNU_variable_value References: <20180802210405.5c04ca7a@pinnacle.lan> <20180802211754.40a529c2@pinnacle.lan> Date: Fri, 03 Aug 2018 18:43:00 -0000 In-Reply-To: <20180802211754.40a529c2@pinnacle.lan> (Kevin Buettner's message of "Thu, 2 Aug 2018 21:17:54 -0700") Message-ID: <87bmaj1ec4.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-08/txt/msg00070.txt.bz2 >>>>> "Kevin" == Kevin Buettner writes: I forgot a note earlier... Kevin> + /* Note: Things still work when the following test is removed. This Kevin> + test and error is here to conform to the proposed specification. */ Kevin> + if (!is_scalar_type (die_type) || TYPE_CODE (die_type) == TYPE_CODE_VOID) Kevin> + error (_("Type of DW_OP_GNU_variable_value DIE must be an integer or pointer.")); I suspect is_scalar_type isn't what you want here. Maybe instead either "is_integral_type || TYPE_CODE == TYPE_CODE_PTR", or just checking for TYPE_CODE_PTR and TYPE_CODE_INT (since, bizarrely to me at least, is_integral_type includes range types). Tom