From: Simon Marchi <simon.marchi@polymtl.ca>
To: Tom Tromey <tom@tromey.com>
Cc: Eli Zaretskii <eliz@gnu.org>, gdb-patches@sourceware.org
Subject: Re: [RFA 1/3] Add new_inferior, inferior_deleted, and new_thread events
Date: Sat, 09 Sep 2017 21:09:00 -0000 [thread overview]
Message-ID: <d2099d8313d0bf66d60a8fa49e13c1a0@polymtl.ca> (raw)
In-Reply-To: <87d16za9l7.fsf@bapiya>
On 2017-09-09 22:41, Tom Tromey wrote:
> I can just make this not be a subclass of ThreadEvent and then clean up
> the docs. Though, there's a PR open about ThreadEvent.inferior_thread
> not being set in the all-stop case.
>
> Tom
I am not sure I understand. Making NewThreadEvent a subclass of
ThreadEvent makes sense to me, since it is an event that concerns one
thread. Right now inferior_thread field of ThreadEvent subclasses is
always None in all-stop, but I don't think it has to stay that way for
new events we introduce (changing the behavior of existing events should
be done more carefully, of course).
Simon
next prev parent reply other threads:[~2017-09-09 21:09 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-09 0:34 [RFA 0/3] add a few Python events Tom Tromey
2017-09-09 0:34 ` [RFA 2/3] Small event ownership clean up in Python layer Tom Tromey
2017-09-09 17:05 ` Simon Marchi
2017-09-09 0:34 ` [RFA 1/3] Add new_inferior, inferior_deleted, and new_thread events Tom Tromey
2017-09-09 6:55 ` Eli Zaretskii
2017-09-09 16:47 ` Simon Marchi
2017-09-09 20:41 ` Tom Tromey
2017-09-09 21:09 ` Simon Marchi [this message]
2017-09-10 0:21 ` Tom Tromey
2017-09-10 19:37 ` Simon Marchi
2017-09-10 21:52 ` Tom Tromey
2017-09-11 11:54 ` Simon Marchi
2017-09-11 14:29 ` Eli Zaretskii
2017-09-09 16:48 ` Simon Marchi
2017-09-09 0:34 ` [RFA 3/3] Make it simpler to add events to Python Tom Tromey
2017-09-09 14:40 ` Tom Tromey
2017-09-09 17:05 ` Simon Marchi
2017-09-10 0:24 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d2099d8313d0bf66d60a8fa49e13c1a0@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox