From: Tom Tromey <tom@tromey.com>
To: Simon Marchi <simon.marchi@polymtl.ca>
Cc: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [RFA 3/3] Make it simpler to add events to Python
Date: Sun, 10 Sep 2017 00:24:00 -0000 [thread overview]
Message-ID: <87vakr8kp6.fsf@bapiya> (raw)
In-Reply-To: <a4216e07cec3ae81735950c56faae0f6@polymtl.ca> (Simon Marchi's message of "Sat, 09 Sep 2017 19:05:05 +0200")
>>>>> "Simon" == Simon Marchi <simon.marchi@polymtl.ca> writes:
Simon> I think it would be clearer if you added the macro "prototype" here,
Simon> otherwise the parameter names refer to nothing.
Simon> GDB_PY_DEFINE_EVENT_TYPE (name, py_path, py_bame, doc, base) ...
Sounds good.
Simon> The py_path and py_name are duplicated everywhere. We could get rid
Simon> of py_path. At the only place where it is used, we can replace it
Simon> with
Simon> "gdb." py_name
Good point.
I've made both of these changes locally.
Tom
prev parent reply other threads:[~2017-09-10 0:24 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-09 0:34 [RFA 0/3] add a few Python events Tom Tromey
2017-09-09 0:34 ` [RFA 2/3] Small event ownership clean up in Python layer Tom Tromey
2017-09-09 17:05 ` Simon Marchi
2017-09-09 0:34 ` [RFA 1/3] Add new_inferior, inferior_deleted, and new_thread events Tom Tromey
2017-09-09 6:55 ` Eli Zaretskii
2017-09-09 16:47 ` Simon Marchi
2017-09-09 20:41 ` Tom Tromey
2017-09-09 21:09 ` Simon Marchi
2017-09-10 0:21 ` Tom Tromey
2017-09-10 19:37 ` Simon Marchi
2017-09-10 21:52 ` Tom Tromey
2017-09-11 11:54 ` Simon Marchi
2017-09-11 14:29 ` Eli Zaretskii
2017-09-09 16:48 ` Simon Marchi
2017-09-09 0:34 ` [RFA 3/3] Make it simpler to add events to Python Tom Tromey
2017-09-09 14:40 ` Tom Tromey
2017-09-09 17:05 ` Simon Marchi
2017-09-10 0:24 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vakr8kp6.fsf@bapiya \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox