From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 58445 invoked by alias); 10 Sep 2017 00:24:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 57792 invoked by uid 89); 10 Sep 2017 00:24:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gproxy9-pub.mail.unifiedlayer.com Received: from gproxy9-pub.mail.unifiedlayer.com (HELO gproxy9-pub.mail.unifiedlayer.com) (69.89.20.122) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 10 Sep 2017 00:24:27 +0000 Received: from cmgw2 (unknown [10.0.90.83]) by gproxy9.mail.unifiedlayer.com (Postfix) with ESMTP id CFC501E0D34 for ; Sat, 9 Sep 2017 18:24:25 -0600 (MDT) Received: from box522.bluehost.com ([74.220.219.122]) by cmgw2 with id 7cQN1w00b2f2jeq01cQRs4; Sat, 09 Sep 2017 18:24:25 -0600 X-Authority-Analysis: v=2.2 cv=dZfw5Tfe c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=2JCJgTwv5E4A:10 a=_ZhYKdCeAAAA:8 a=NDYQIznUQ5k3zZE2DXwA:9 a=uqOk3ZSnBfCTOznnrPA1:22 Received: from 75-166-76-94.hlrn.qwest.net ([75.166.76.94]:44148 helo=bapiya) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.87) (envelope-from ) id 1dqq2w-000234-GT; Sat, 09 Sep 2017 18:24:22 -0600 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFA 3/3] Make it simpler to add events to Python References: <20170909003353.25883-1-tom@tromey.com> <20170909003353.25883-4-tom@tromey.com> Date: Sun, 10 Sep 2017 00:24:00 -0000 In-Reply-To: (Simon Marchi's message of "Sat, 09 Sep 2017 19:05:05 +0200") Message-ID: <87vakr8kp6.fsf@bapiya> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Exim-ID: 1dqq2w-000234-GT X-Source-Sender: 75-166-76-94.hlrn.qwest.net (bapiya) [75.166.76.94]:44148 X-Source-Auth: tom+tromey.com X-Email-Count: 5 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-Local-Domain: yes X-SW-Source: 2017-09/txt/msg00263.txt.bz2 >>>>> "Simon" == Simon Marchi writes: Simon> I think it would be clearer if you added the macro "prototype" here, Simon> otherwise the parameter names refer to nothing. Simon> GDB_PY_DEFINE_EVENT_TYPE (name, py_path, py_bame, doc, base) ... Sounds good. Simon> The py_path and py_name are duplicated everywhere. We could get rid Simon> of py_path. At the only place where it is used, we can replace it Simon> with Simon> "gdb." py_name Good point. I've made both of these changes locally. Tom