From: Tom Tromey <tom@tromey.com>
To: Simon Marchi <simon.marchi@polymtl.ca>
Cc: Eli Zaretskii <eliz@gnu.org>, Tom Tromey <tom@tromey.com>,
gdb-patches@sourceware.org
Subject: Re: [RFA 1/3] Add new_inferior, inferior_deleted, and new_thread events
Date: Sat, 09 Sep 2017 20:41:00 -0000 [thread overview]
Message-ID: <87d16za9l7.fsf@bapiya> (raw)
In-Reply-To: <f61366dead6201a92358f23ab9b45d1c@polymtl.ca> (Simon Marchi's message of "Sat, 09 Sep 2017 18:46:57 +0200")
Simon> I find the resulting documentation page about Python Events a bit hard
Simon> to follow. The "events.new_thread" event registry refers to the
Simon> gdb.ThreadEvent type, which itself is defined under the "events.cont"
Simon> registry. There it says that inferior_thread is always not None in
Simon> none-stop, and always None in all-stop. That is contradictory with
Simon> the text under "events.new_thread". If it is possible for event types
Simon> to be emitted by different event registries, I think they should be
Simon> documented separately (on the same page, but in two sections).
I can just make this not be a subclass of ThreadEvent and then clean up
the docs. Though, there's a PR open about ThreadEvent.inferior_thread
not being set in the all-stop case.
Tom
next prev parent reply other threads:[~2017-09-09 20:41 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-09 0:34 [RFA 0/3] add a few Python events Tom Tromey
2017-09-09 0:34 ` [RFA 1/3] Add new_inferior, inferior_deleted, and new_thread events Tom Tromey
2017-09-09 6:55 ` Eli Zaretskii
2017-09-09 16:47 ` Simon Marchi
2017-09-09 20:41 ` Tom Tromey [this message]
2017-09-09 21:09 ` Simon Marchi
2017-09-10 0:21 ` Tom Tromey
2017-09-10 19:37 ` Simon Marchi
2017-09-10 21:52 ` Tom Tromey
2017-09-11 11:54 ` Simon Marchi
2017-09-11 14:29 ` Eli Zaretskii
2017-09-09 16:48 ` Simon Marchi
2017-09-09 0:34 ` [RFA 3/3] Make it simpler to add events to Python Tom Tromey
2017-09-09 14:40 ` Tom Tromey
2017-09-09 17:05 ` Simon Marchi
2017-09-10 0:24 ` Tom Tromey
2017-09-09 0:34 ` [RFA 2/3] Small event ownership clean up in Python layer Tom Tromey
2017-09-09 17:05 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d16za9l7.fsf@bapiya \
--to=tom@tromey.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox