From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 90184 invoked by alias); 9 Sep 2017 20:41:31 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 90173 invoked by uid 89); 9 Sep 2017 20:41:31 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gproxy3-pub.mail.unifiedlayer.com Received: from gproxy3-pub.mail.unifiedlayer.com (HELO gproxy3-pub.mail.unifiedlayer.com) (69.89.30.42) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 09 Sep 2017 20:41:30 +0000 Received: from cmgw4 (unknown [10.0.90.85]) by gproxy3.mail.unifiedlayer.com (Postfix) with ESMTP id CFBAF4005F for ; Sat, 9 Sep 2017 14:41:28 -0600 (MDT) Received: from box522.bluehost.com ([74.220.219.122]) by cmgw4 with id 7YhR1w00W2f2jeq01YhU36; Sat, 09 Sep 2017 14:41:28 -0600 X-Authority-Analysis: v=2.2 cv=OZLoNlbY c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=2JCJgTwv5E4A:10 a=kqwT1m52Ce706c_APxMA:9 Received: from 75-166-76-94.hlrn.qwest.net ([75.166.76.94]:42586 helo=bapiya) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.87) (envelope-from ) id 1dqmZB-001zki-EY; Sat, 09 Sep 2017 14:41:25 -0600 From: Tom Tromey To: Simon Marchi Cc: Eli Zaretskii , Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFA 1/3] Add new_inferior, inferior_deleted, and new_thread events References: <20170909003353.25883-1-tom@tromey.com> <20170909003353.25883-2-tom@tromey.com> <831sngxsxi.fsf@gnu.org> Date: Sat, 09 Sep 2017 20:41:00 -0000 In-Reply-To: (Simon Marchi's message of "Sat, 09 Sep 2017 18:46:57 +0200") Message-ID: <87d16za9l7.fsf@bapiya> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Exim-ID: 1dqmZB-001zki-EY X-Source-Sender: 75-166-76-94.hlrn.qwest.net (bapiya) [75.166.76.94]:42586 X-Source-Auth: tom+tromey.com X-Email-Count: 3 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-Local-Domain: yes X-SW-Source: 2017-09/txt/msg00259.txt.bz2 Simon> I find the resulting documentation page about Python Events a bit hard Simon> to follow. The "events.new_thread" event registry refers to the Simon> gdb.ThreadEvent type, which itself is defined under the "events.cont" Simon> registry. There it says that inferior_thread is always not None in Simon> none-stop, and always None in all-stop. That is contradictory with Simon> the text under "events.new_thread". If it is possible for event types Simon> to be emitted by different event registries, I think they should be Simon> documented separately (on the same page, but in two sections). I can just make this not be a subclass of ThreadEvent and then clean up the docs. Though, there's a PR open about ThreadEvent.inferior_thread not being set in the all-stop case. Tom