From: Simon Marchi <simon.marchi@polymtl.ca>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [RFA 1/3] Add new_inferior, inferior_deleted, and new_thread events
Date: Sat, 09 Sep 2017 16:47:00 -0000 [thread overview]
Message-ID: <f61366dead6201a92358f23ab9b45d1c@polymtl.ca> (raw)
In-Reply-To: <831sngxsxi.fsf@gnu.org>
On 2017-09-09 08:55, Eli Zaretskii wrote:
>> From: Tom Tromey <tom@tromey.com>
>> Cc: Tom Tromey <tom@tromey.com>
>> Date: Fri, 8 Sep 2017 18:33:51 -0600
>>
>> This adds a few new events to gdb's Python layer: new_inferior,
>> inferior_deleted, and new_thread. I wanted to be able to add a
>> combined inferior/thread display window to my GUI, and I needed a few
>> events to make this work. This is PR python/15622.
>>
>> gdb/ChangeLog
>> 2017-09-08 Tom Tromey <tom@tromey.com>
>>
>> PR python/15622:
>> * NEWS: Add entry.
>> * python/python.c (do_start_initialization): Initialize new event
>> types.
>> * python/python-internal.h (gdbpy_initialize_new_inferior_event)
>> (gdbpy_initialize_inferior_deleted_event)
>> (gdbpy_initialize_new_thread_event): Declare.
>> * python/py-threadevent.c (create_thread_event_object): Add option
>> "thread" parameter.
>> * python/py-inferior.c (new_thread_event_object_type)
>> (new_inferior_event_object_type)
>> (inferior_deleted_event_object_type): Declare.
>> (python_new_inferior, python_inferior_deleted): New functions.
>> (add_thread_object): Emit new_thread event.
>> (gdbpy_initialize_inferior): Attach new functions to corresponding
>> observers.
>> (new_thread, new_inferior, inferior_deleted): Define new event
>> types.
>> * python/py-evts.c (gdbpy_initialize_py_events): Add new
>> registries.
>> * python/py-events.h (events_object) <new_inferior,
>> inferior_deleted, new_thread>: New fields.
>> * python/py-event.h (create_thread_event_breakpoint): Add optional
>> "thread" parameter.
>>
>> gdb/doc/ChangeLog
>> 2017-09-08 Tom Tromey <tom@tromey.com>
>>
>> * python.texi (Events In Python): Document new events.
>>
>> gdb/testsuite/ChangeLog
>> 2017-09-08 Tom Tromey <tom@tromey.com>
>>
>> * gdb.python/py-infthread.exp: Add tests for new_thread event.
>> * gdb.python/py-inferior.exp: Add tests for new inferior events.
>
> OK for the documentation parts.
>
> Thanks.
I find the resulting documentation page about Python Events a bit hard
to follow. The "events.new_thread" event registry refers to the
gdb.ThreadEvent type, which itself is defined under the "events.cont"
registry. There it says that inferior_thread is always not None in
none-stop, and always None in all-stop. That is contradictory with the
text under "events.new_thread". If it is possible for event types to be
emitted by different event registries, I think they should be documented
separately (on the same page, but in two sections).
Simon
next prev parent reply other threads:[~2017-09-09 16:47 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-09 0:34 [RFA 0/3] add a few Python events Tom Tromey
2017-09-09 0:34 ` [RFA 2/3] Small event ownership clean up in Python layer Tom Tromey
2017-09-09 17:05 ` Simon Marchi
2017-09-09 0:34 ` [RFA 1/3] Add new_inferior, inferior_deleted, and new_thread events Tom Tromey
2017-09-09 6:55 ` Eli Zaretskii
2017-09-09 16:47 ` Simon Marchi [this message]
2017-09-09 20:41 ` Tom Tromey
2017-09-09 21:09 ` Simon Marchi
2017-09-10 0:21 ` Tom Tromey
2017-09-10 19:37 ` Simon Marchi
2017-09-10 21:52 ` Tom Tromey
2017-09-11 11:54 ` Simon Marchi
2017-09-11 14:29 ` Eli Zaretskii
2017-09-09 16:48 ` Simon Marchi
2017-09-09 0:34 ` [RFA 3/3] Make it simpler to add events to Python Tom Tromey
2017-09-09 14:40 ` Tom Tromey
2017-09-09 17:05 ` Simon Marchi
2017-09-10 0:24 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f61366dead6201a92358f23ab9b45d1c@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox