From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 122679 invoked by alias); 9 Sep 2017 21:09:29 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 122669 invoked by uid 89); 9 Sep 2017 21:09:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 09 Sep 2017 21:09:27 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id v89L9GPZ013981 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Sat, 9 Sep 2017 17:09:23 -0400 Received: by simark.ca (Postfix, from userid 112) id 2F34D1EAB3; Sat, 9 Sep 2017 17:09:16 -0400 (EDT) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id 4D44A1EA18; Sat, 9 Sep 2017 17:09:15 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Sat, 09 Sep 2017 21:09:00 -0000 From: Simon Marchi To: Tom Tromey Cc: Eli Zaretskii , gdb-patches@sourceware.org Subject: Re: [RFA 1/3] Add new_inferior, inferior_deleted, and new_thread events In-Reply-To: <87d16za9l7.fsf@bapiya> References: <20170909003353.25883-1-tom@tromey.com> <20170909003353.25883-2-tom@tromey.com> <831sngxsxi.fsf@gnu.org> <87d16za9l7.fsf@bapiya> Message-ID: X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.0 X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Sat, 9 Sep 2017 21:09:16 +0000 X-IsSubscribed: yes X-SW-Source: 2017-09/txt/msg00261.txt.bz2 On 2017-09-09 22:41, Tom Tromey wrote: > I can just make this not be a subclass of ThreadEvent and then clean up > the docs. Though, there's a PR open about ThreadEvent.inferior_thread > not being set in the all-stop case. > > Tom I am not sure I understand. Making NewThreadEvent a subclass of ThreadEvent makes sense to me, since it is an event that concerns one thread. Right now inferior_thread field of ThreadEvent subclasses is always None in all-stop, but I don't think it has to stay that way for new events we introduce (changing the behavior of existing events should be done more carefully, of course). Simon