From: Pedro Alves <palves@redhat.com>
To: "Tedeschi, Walfred" <walfred.tedeschi@intel.com>,
Simon Marchi <simon.marchi@polymtl.ca>
Cc: qiyaoltc@gmail.com, gdb-patches@sourceware.org
Subject: Re: [PATCH] icc: allow code path for newer versions of icc.
Date: Wed, 20 Sep 2017 15:45:00 -0000 [thread overview]
Message-ID: <cd49d371-7265-0e53-9f33-ab53e59f97ea@redhat.com> (raw)
In-Reply-To: <a83f63ef-65cb-25f1-0cfc-585c21172b18@intel.com>
On 09/20/2017 03:17 PM, Tedeschi, Walfred wrote:
> Hello Simon and Pedro,
>
> I have prepared a cleaning patch first and another one with the icc
> version check.
>
> The changes are in:
> users/wtedesch/icc_version
>
> Comments are welcome!
Thanks!
Speaking for myself, while a git branch is handy for trying
locally (and I tend to push changes to branches too to help
others for larger series, in addition to posting on the list),
I still find it easier to reply/review to patches sent via email,
because that allows conveniently quoting patches.
But I went ahead and took a quick look. I have to say that
don't care for the "dwarf2utils" name much BTW. My issue with
"utils.h|c" is that "utils" is a kitchen sync name; almost anything
can be called an "utility". And "dwarf2utils" has almost the same
issue, in my view. Note that I had suggested producers.h/c without
a "dwarf" qualification because the producers string is exposed
in generic code, through symtab.h:compunit_symtab etc.
(even though the producers info is currently only sourced
from DWARF info).
As for the the rest, it seems like several previous comments
haven't been addressed yet, so I'll wait for a repost.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2017-09-20 15:45 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-06 8:47 Walfred Tedeschi
2017-09-06 8:47 ` [PATCH] symlookup: improves symbol lookup when a file is specified Walfred Tedeschi
2017-09-20 15:22 ` [ping][PATCH] " Tedeschi, Walfred
2017-10-09 7:35 ` Tedeschi, Walfred
2017-10-09 12:42 ` [PATCH] " Pedro Alves
2017-10-09 14:06 ` Tedeschi, Walfred
2017-09-06 8:47 ` [PATCH] gdb - avx512: tests were failing due to missing memory aligment Walfred Tedeschi
2017-09-16 13:57 ` Simon Marchi
2017-09-17 20:22 ` Yao Qi
2017-09-18 14:18 ` Tedeschi, Walfred
2017-09-20 13:39 ` [pushed] " Tedeschi, Walfred
2017-09-16 13:49 ` [PATCH] icc: allow code path for newer versions of icc Simon Marchi
2017-09-18 14:17 ` Tedeschi, Walfred
2017-09-18 15:34 ` Pedro Alves
2017-09-18 16:24 ` Simon Marchi
2017-09-18 16:34 ` Tedeschi, Walfred
2017-09-18 19:13 ` Simon Marchi
2017-09-20 15:19 ` Tedeschi, Walfred
2017-09-20 15:45 ` Pedro Alves [this message]
2017-09-20 15:55 ` Tedeschi, Walfred
2017-09-21 11:27 ` Tedeschi, Walfred
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cd49d371-7265-0e53-9f33-ab53e59f97ea@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=qiyaoltc@gmail.com \
--cc=simon.marchi@polymtl.ca \
--cc=walfred.tedeschi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox