From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 463 invoked by alias); 20 Sep 2017 15:45:41 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 454 invoked by uid 89); 20 Sep 2017 15:45:40 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1269, conveniently, Comments, kitchen X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 20 Sep 2017 15:45:39 +0000 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 85CD34A708; Wed, 20 Sep 2017 15:45:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 85CD34A708 Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=palves@redhat.com Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id D13CC5D75D; Wed, 20 Sep 2017 15:45:36 +0000 (UTC) Subject: Re: [PATCH] icc: allow code path for newer versions of icc. To: "Tedeschi, Walfred" , Simon Marchi References: <1504687613-14649-1-git-send-email-walfred.tedeschi@intel.com> <59e18301-7b12-2e92-6277-0aef4164243e@redhat.com> <914ad9ed-940e-81e1-e7de-6c018d29aec7@intel.com> <4bc75ec493ddeb1500c51812a51e8182@polymtl.ca> Cc: qiyaoltc@gmail.com, gdb-patches@sourceware.org From: Pedro Alves Message-ID: Date: Wed, 20 Sep 2017 15:45:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-09/txt/msg00496.txt.bz2 On 09/20/2017 03:17 PM, Tedeschi, Walfred wrote: > Hello Simon and Pedro, > > I have prepared a cleaning patch first and another one with the icc > version check. > > The changes are in: > users/wtedesch/icc_version > > Comments are welcome! Thanks! Speaking for myself, while a git branch is handy for trying locally (and I tend to push changes to branches too to help others for larger series, in addition to posting on the list), I still find it easier to reply/review to patches sent via email, because that allows conveniently quoting patches. But I went ahead and took a quick look. I have to say that don't care for the "dwarf2utils" name much BTW. My issue with "utils.h|c" is that "utils" is a kitchen sync name; almost anything can be called an "utility". And "dwarf2utils" has almost the same issue, in my view. Note that I had suggested producers.h/c without a "dwarf" qualification because the producers string is exposed in generic code, through symtab.h:compunit_symtab etc. (even though the producers info is currently only sourced from DWARF info). As for the the rest, it seems like several previous comments haven't been addressed yet, so I'll wait for a repost. Thanks, Pedro Alves