RE: [PATCH] icc: allow code path for newer versions of icc.

Tedeschi, Walfred
2017-09-20T15:55:25Z

-----Original Message-----
From: gdb-patches-owner@sourceware.org [mailto:gdb-patches-owner@sourceware.org] On Behalf Of Pedro Alves
Sent: Wednesday, September 20, 2017 5:46 PM
To: Tedeschi, Walfred <walfred.tedeschi@intel.com>; Simon Marchi <simon.marchi@polymtl.ca>
Cc: qiyaoltc@gmail.com; gdb-patches@sourceware.org
Subject: Re: [PATCH] icc: allow code path for newer versions of icc.

On 09/20/2017 03:17 PM, Tedeschi, Walfred wrote:

> Hello Simon and Pedro,
>
> I have prepared a cleaning patch first and another one with the icc
> version check.
>
> The changes are in:
> users/wtedesch/icc_version
>
> Comments are welcome!

Thanks!

Speaking for myself, while a git branch is handy for trying locally (and I tend to push changes to branches too to help others for larger series, in addition to posting on the list), I still find it easier to reply/review to patches sent via email, because that allows conveniently quoting patches.

But I went ahead and took a quick look. I have to say that don't care for the "dwarf2utils" name much BTW. My issue with "utils.h|c" is that "utils" is a kitchen sync name; almost anything can be called an "utility". And "dwarf2utils" has almost the same issue, in my view. Note that I had suggested producers.h/c without a "dwarf" qualification because the producers string is exposed in generic code, through symtab.h:compunit_symtab etc.
(even though the producers info is currently only sourced from DWARF info).

As for the the rest, it seems like several previous comments haven't been addressed yet, so I'll wait for a repost.

Thanks,
Pedro Alves

Pedro,

Thanks for your quick answer!

I will prepare new patches.

Thanks and regards,
/Fred
Intel Deutschland GmbH
Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Christin Eisenschmid, Christian Lamprechter
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928