From: Simon Marchi <simon.marchi@polymtl.ca>
To: "Tedeschi, Walfred" <walfred.tedeschi@intel.com>
Cc: Pedro Alves <palves@redhat.com>,
qiyaoltc@gmail.com, gdb-patches@sourceware.org
Subject: Re: [PATCH] icc: allow code path for newer versions of icc.
Date: Mon, 18 Sep 2017 19:13:00 -0000 [thread overview]
Message-ID: <4bc75ec493ddeb1500c51812a51e8182@polymtl.ca> (raw)
In-Reply-To: <914ad9ed-940e-81e1-e7de-6c018d29aec7@intel.com>
On 2017-09-18 17:31, Tedeschi, Walfred wrote:
> I am considering sending then two patches:
> 1. Add things in utils.c
> 2. move all producers to a new producers.h/c file.
>
> Would this be ok?
(I am just speaking for myself)
I usually prefer the opposite, cleanup first then add new features
(because sometimes the cleanup is promised and never comes :)), but
really I'm fine with both. The fact that you are ready to do some
cleanup is appreciated.
Simon
next prev parent reply other threads:[~2017-09-18 19:13 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-06 8:47 Walfred Tedeschi
2017-09-06 8:47 ` [PATCH] symlookup: improves symbol lookup when a file is specified Walfred Tedeschi
2017-09-20 15:22 ` [ping][PATCH] " Tedeschi, Walfred
2017-10-09 7:35 ` Tedeschi, Walfred
2017-10-09 12:42 ` [PATCH] " Pedro Alves
2017-10-09 14:06 ` Tedeschi, Walfred
2017-09-06 8:47 ` [PATCH] gdb - avx512: tests were failing due to missing memory aligment Walfred Tedeschi
2017-09-16 13:57 ` Simon Marchi
2017-09-17 20:22 ` Yao Qi
2017-09-18 14:18 ` Tedeschi, Walfred
2017-09-20 13:39 ` [pushed] " Tedeschi, Walfred
2017-09-16 13:49 ` [PATCH] icc: allow code path for newer versions of icc Simon Marchi
2017-09-18 14:17 ` Tedeschi, Walfred
2017-09-18 15:34 ` Pedro Alves
2017-09-18 16:24 ` Simon Marchi
2017-09-18 16:34 ` Tedeschi, Walfred
2017-09-18 19:13 ` Simon Marchi [this message]
2017-09-20 15:19 ` Tedeschi, Walfred
2017-09-20 15:45 ` Pedro Alves
2017-09-20 15:55 ` Tedeschi, Walfred
2017-09-21 11:27 ` Tedeschi, Walfred
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4bc75ec493ddeb1500c51812a51e8182@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=qiyaoltc@gmail.com \
--cc=walfred.tedeschi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox