From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 47689 invoked by alias); 18 Sep 2017 19:13:22 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 47680 invoked by uid 89); 18 Sep 2017 19:13:22 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=promised X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 18 Sep 2017 19:13:20 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id v8IJDEmC012817 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 18 Sep 2017 15:13:18 -0400 Received: by simark.ca (Postfix, from userid 112) id 16CA01ECF5; Mon, 18 Sep 2017 15:13:14 -0400 (EDT) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id 3C7F91E5B9; Mon, 18 Sep 2017 15:13:13 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 18 Sep 2017 19:13:00 -0000 From: Simon Marchi To: "Tedeschi, Walfred" Cc: Pedro Alves , qiyaoltc@gmail.com, gdb-patches@sourceware.org Subject: Re: [PATCH] icc: allow code path for newer versions of icc. In-Reply-To: <914ad9ed-940e-81e1-e7de-6c018d29aec7@intel.com> References: <1504687613-14649-1-git-send-email-walfred.tedeschi@intel.com> <59e18301-7b12-2e92-6277-0aef4164243e@redhat.com> <914ad9ed-940e-81e1-e7de-6c018d29aec7@intel.com> Message-ID: <4bc75ec493ddeb1500c51812a51e8182@polymtl.ca> X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.0 X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Mon, 18 Sep 2017 19:13:14 +0000 X-IsSubscribed: yes X-SW-Source: 2017-09/txt/msg00455.txt.bz2 On 2017-09-18 17:31, Tedeschi, Walfred wrote: > I am considering sending then two patches: > 1. Add things in utils.c > 2. move all producers to a new producers.h/c file. > > Would this be ok? (I am just speaking for myself) I usually prefer the opposite, cleanup first then add new features (because sometimes the cleanup is promised and never comes :)), but really I'm fine with both. The fact that you are ready to do some cleanup is appreciated. Simon