From: "Tedeschi, Walfred" <walfred.tedeschi@intel.com>
To: Pedro Alves <palves@redhat.com>, Simon Marchi <simon.marchi@polymtl.ca>
Cc: "qiyaoltc@gmail.com" <qiyaoltc@gmail.com>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: RE: [PATCH] icc: allow code path for newer versions of icc.
Date: Thu, 21 Sep 2017 11:27:00 -0000 [thread overview]
Message-ID: <AC542571535E904D8E8ADAE745D60B197A99307B@IRSMSX104.ger.corp.intel.com> (raw)
In-Reply-To: <cd49d371-7265-0e53-9f33-ab53e59f97ea@redhat.com>
-----Original Message-----
From: gdb-patches-owner@sourceware.org [mailto:gdb-patches-owner@sourceware.org] On Behalf Of Pedro Alves
Sent: Wednesday, September 20, 2017 5:46 PM
To: Tedeschi, Walfred <walfred.tedeschi@intel.com>; Simon Marchi <simon.marchi@polymtl.ca>
Cc: qiyaoltc@gmail.com; gdb-patches@sourceware.org
Subject: Re: [PATCH] icc: allow code path for newer versions of icc.
On 09/20/2017 03:17 PM, Tedeschi, Walfred wrote:
>> Hello Simon and Pedro,
>>
>> I have prepared a cleaning patch first and another one with the icc
>> version check.
>>
>> The changes are in:
>> users/wtedesch/icc_version
>>
>> Comments are welcome!
>
>Thanks!
>
>Speaking for myself, while a git branch is handy for trying locally (and I tend to push changes to branches too to help others for larger series, in >addition to posting on the list), I still find it easier to reply/review to patches sent via email, because that allows conveniently quoting patches. >
>
>But I went ahead and took a quick look. I have to say that don't care for the "dwarf2utils" name much BTW. My issue with "utils.h|c" is that >"utils" is a kitchen sync name; almost anything can be called an "utility". And "dwarf2utils" has almost the same issue, in my view. Note that I >had suggested producers.h/c without a "dwarf" qualification because the producers string is exposed in generic code, through >symtab.h:compunit_symtab etc.
> (even though the producers info is currently only sourced from DWARF info).
>
>As for the the rest, it seems like several previous comments haven't been addressed yet, so I'll wait for a repost.
>
>Thanks,
>Pedro Alves
Hello Pedro,
Thanks for the quick reply!
My concern with the name was to create a file that could be used for more things, but not much more.
Do you consider a better approach to have a specialized file, having only the producers on it?
Best regards,
/Fred
Intel Deutschland GmbH
Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Christin Eisenschmid, Christian Lamprechter
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928
prev parent reply other threads:[~2017-09-21 11:27 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-06 8:47 Walfred Tedeschi
2017-09-06 8:47 ` [PATCH] gdb - avx512: tests were failing due to missing memory aligment Walfred Tedeschi
2017-09-16 13:57 ` Simon Marchi
2017-09-17 20:22 ` Yao Qi
2017-09-18 14:18 ` Tedeschi, Walfred
2017-09-20 13:39 ` [pushed] " Tedeschi, Walfred
2017-09-06 8:47 ` [PATCH] symlookup: improves symbol lookup when a file is specified Walfred Tedeschi
2017-09-20 15:22 ` [ping][PATCH] " Tedeschi, Walfred
2017-10-09 7:35 ` Tedeschi, Walfred
2017-10-09 12:42 ` [PATCH] " Pedro Alves
2017-10-09 14:06 ` Tedeschi, Walfred
2017-09-16 13:49 ` [PATCH] icc: allow code path for newer versions of icc Simon Marchi
2017-09-18 14:17 ` Tedeschi, Walfred
2017-09-18 15:34 ` Pedro Alves
2017-09-18 16:24 ` Simon Marchi
2017-09-18 16:34 ` Tedeschi, Walfred
2017-09-18 19:13 ` Simon Marchi
2017-09-20 15:19 ` Tedeschi, Walfred
2017-09-20 15:45 ` Pedro Alves
2017-09-20 15:55 ` Tedeschi, Walfred
2017-09-21 11:27 ` Tedeschi, Walfred [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AC542571535E904D8E8ADAE745D60B197A99307B@IRSMSX104.ger.corp.intel.com \
--to=walfred.tedeschi@intel.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=qiyaoltc@gmail.com \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox