From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26940 invoked by alias); 21 Sep 2017 11:27:43 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 26930 invoked by uid 89); 21 Sep 2017 11:27:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-6.5 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,MIME_BASE64_BLANKS,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=reply! X-HELO: mga09.intel.com Received: from mga09.intel.com (HELO mga09.intel.com) (134.134.136.24) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 21 Sep 2017 11:27:42 +0000 Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Sep 2017 04:27:39 -0700 X-ExtLoop1: 1 Received: from irsmsx154.ger.corp.intel.com ([163.33.192.96]) by fmsmga004.fm.intel.com with ESMTP; 21 Sep 2017 04:27:37 -0700 Received: from irsmsx104.ger.corp.intel.com ([169.254.5.248]) by IRSMSX154.ger.corp.intel.com ([169.254.12.83]) with mapi id 14.03.0319.002; Thu, 21 Sep 2017 12:27:37 +0100 From: "Tedeschi, Walfred" To: Pedro Alves , Simon Marchi CC: "qiyaoltc@gmail.com" , "gdb-patches@sourceware.org" Subject: RE: [PATCH] icc: allow code path for newer versions of icc. Date: Thu, 21 Sep 2017 11:27:00 -0000 Message-ID: References: <1504687613-14649-1-git-send-email-walfred.tedeschi@intel.com> <59e18301-7b12-2e92-6277-0aef4164243e@redhat.com> <914ad9ed-940e-81e1-e7de-6c018d29aec7@intel.com> <4bc75ec493ddeb1500c51812a51e8182@polymtl.ca> In-Reply-To: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 X-IsSubscribed: yes X-SW-Source: 2017-09/txt/msg00618.txt.bz2 LS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCkZyb206IGdkYi1wYXRjaGVz LW93bmVyQHNvdXJjZXdhcmUub3JnIFttYWlsdG86Z2RiLXBhdGNoZXMtb3du ZXJAc291cmNld2FyZS5vcmddIE9uIEJlaGFsZiBPZiBQZWRybyBBbHZlcw0K U2VudDogV2VkbmVzZGF5LCBTZXB0ZW1iZXIgMjAsIDIwMTcgNTo0NiBQTQ0K VG86IFRlZGVzY2hpLCBXYWxmcmVkIDx3YWxmcmVkLnRlZGVzY2hpQGludGVs LmNvbT47IFNpbW9uIE1hcmNoaSA8c2ltb24ubWFyY2hpQHBvbHltdGwuY2E+ DQpDYzogcWl5YW9sdGNAZ21haWwuY29tOyBnZGItcGF0Y2hlc0Bzb3VyY2V3 YXJlLm9yZw0KU3ViamVjdDogUmU6IFtQQVRDSF0gaWNjOiBhbGxvdyBjb2Rl IHBhdGggZm9yIG5ld2VyIHZlcnNpb25zIG9mIGljYy4NCg0KT24gMDkvMjAv MjAxNyAwMzoxNyBQTSwgVGVkZXNjaGksIFdhbGZyZWQgd3JvdGU6DQoNCj4+ IEhlbGxvIFNpbW9uIGFuZCBQZWRybywNCj4+IA0KPj4gSSBoYXZlIHByZXBh cmVkIGEgY2xlYW5pbmcgcGF0Y2ggZmlyc3QgYW5kIGFub3RoZXIgb25lIHdp dGggdGhlIGljYyANCj4+IHZlcnNpb24gY2hlY2suDQo+PiANCj4+IFRoZSBj aGFuZ2VzIGFyZSBpbjoNCj4+IHVzZXJzL3d0ZWRlc2NoL2ljY192ZXJzaW9u DQo+PiANCj4+IENvbW1lbnRzIGFyZSB3ZWxjb21lIQ0KPg0KPlRoYW5rcyEN Cj4NCj5TcGVha2luZyBmb3IgbXlzZWxmLCB3aGlsZSBhIGdpdCBicmFuY2gg aXMgaGFuZHkgZm9yIHRyeWluZyBsb2NhbGx5IChhbmQgSSB0ZW5kIHRvIHB1 c2ggY2hhbmdlcyB0byBicmFuY2hlcyB0b28gdG8gaGVscCBvdGhlcnMgZm9y IGxhcmdlciBzZXJpZXMsIGluID5hZGRpdGlvbiB0byBwb3N0aW5nIG9uIHRo ZSBsaXN0KSwgSSBzdGlsbCBmaW5kIGl0IGVhc2llciB0byByZXBseS9yZXZp ZXcgdG8gcGF0Y2hlcyBzZW50IHZpYSBlbWFpbCwgYmVjYXVzZSB0aGF0IGFs bG93cyBjb252ZW5pZW50bHkgcXVvdGluZyBwYXRjaGVzLiA+DQo+DQo+QnV0 IEkgd2VudCBhaGVhZCBhbmQgdG9vayBhIHF1aWNrIGxvb2suICBJIGhhdmUg dG8gc2F5IHRoYXQgZG9uJ3QgY2FyZSBmb3IgdGhlICJkd2FyZjJ1dGlscyIg bmFtZSBtdWNoIEJUVy4gIE15IGlzc3VlIHdpdGggInV0aWxzLmh8YyIgaXMg dGhhdCA+InV0aWxzIiBpcyBhIGtpdGNoZW4gc3luYyBuYW1lOyBhbG1vc3Qg YW55dGhpbmcgY2FuIGJlIGNhbGxlZCBhbiAidXRpbGl0eSIuICBBbmQgImR3 YXJmMnV0aWxzIiBoYXMgYWxtb3N0IHRoZSBzYW1lIGlzc3VlLCBpbiBteSB2 aWV3LiAgTm90ZSB0aGF0IEkgPmhhZCBzdWdnZXN0ZWQgcHJvZHVjZXJzLmgv YyB3aXRob3V0IGEgImR3YXJmIiBxdWFsaWZpY2F0aW9uIGJlY2F1c2UgdGhl IHByb2R1Y2VycyBzdHJpbmcgaXMgZXhwb3NlZCBpbiBnZW5lcmljIGNvZGUs IHRocm91Z2ggPnN5bXRhYi5oOmNvbXB1bml0X3N5bXRhYiBldGMuDQo+IChl dmVuIHRob3VnaCB0aGUgcHJvZHVjZXJzIGluZm8gaXMgY3VycmVudGx5IG9u bHkgc291cmNlZCBmcm9tIERXQVJGIGluZm8pLg0KPg0KPkFzIGZvciB0aGUg dGhlIHJlc3QsIGl0IHNlZW1zIGxpa2Ugc2V2ZXJhbCBwcmV2aW91cyBjb21t ZW50cyBoYXZlbid0IGJlZW4gYWRkcmVzc2VkIHlldCwgc28gSSdsbCB3YWl0 IGZvciBhIHJlcG9zdC4gDQo+DQo+VGhhbmtzLA0KPlBlZHJvIEFsdmVzDQoN CkhlbGxvIFBlZHJvLA0KDQpUaGFua3MgZm9yIHRoZSBxdWljayByZXBseSEN Cg0KTXkgY29uY2VybiB3aXRoIHRoZSBuYW1lIHdhcyB0byBjcmVhdGUgYSBm aWxlIHRoYXQgY291bGQgYmUgdXNlZCBmb3IgbW9yZSB0aGluZ3MsIGJ1dCBu b3QgbXVjaCBtb3JlLg0KRG8geW91IGNvbnNpZGVyIGEgYmV0dGVyIGFwcHJv YWNoIHRvIGhhdmUgYSBzcGVjaWFsaXplZCBmaWxlLCBoYXZpbmcgb25seSB0 aGUgcHJvZHVjZXJzIG9uIGl0Pw0KDQpCZXN0IHJlZ2FyZHMsDQovRnJlZA0K SW50ZWwgRGV1dHNjaGxhbmQgR21iSApSZWdpc3RlcmVkIEFkZHJlc3M6IEFt IENhbXBlb24gMTAtMTIsIDg1NTc5IE5ldWJpYmVyZywgR2VybWFueQpUZWw6 ICs0OSA4OSA5OSA4ODUzLTAsIHd3dy5pbnRlbC5kZQpNYW5hZ2luZyBEaXJl Y3RvcnM6IENocmlzdGluIEVpc2Vuc2NobWlkLCBDaHJpc3RpYW4gTGFtcHJl Y2h0ZXIKQ2hhaXJwZXJzb24gb2YgdGhlIFN1cGVydmlzb3J5IEJvYXJkOiBO aWNvbGUgTGF1ClJlZ2lzdGVyZWQgT2ZmaWNlOiBNdW5pY2gKQ29tbWVyY2lh bCBSZWdpc3RlcjogQW10c2dlcmljaHQgTXVlbmNoZW4gSFJCIDE4NjkyOAo= >From gdb-patches-return-141885-listarch-gdb-patches=sources.redhat.com@sourceware.org Thu Sep 21 12:03:53 2017 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 49486 invoked by alias); 21 Sep 2017 12:03:53 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 49477 invoked by uid 89); 21 Sep 2017 12:03:52 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=kitchen X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 21 Sep 2017 12:03:51 +0000 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id AF7C7821C3; Thu, 21 Sep 2017 12:03:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com AF7C7821C3 Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=palves@redhat.com Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id A93A35D982; Thu, 21 Sep 2017 12:03:49 +0000 (UTC) Subject: Re: [PATCH] icc: allow code path for newer versions of icc. To: "Tedeschi, Walfred" , Simon Marchi References: <1504687613-14649-1-git-send-email-walfred.tedeschi@intel.com> <59e18301-7b12-2e92-6277-0aef4164243e@redhat.com> <914ad9ed-940e-81e1-e7de-6c018d29aec7@intel.com> <4bc75ec493ddeb1500c51812a51e8182@polymtl.ca> Cc: "qiyaoltc@gmail.com" , "gdb-patches@sourceware.org" From: Pedro Alves Message-ID: Date: Thu, 21 Sep 2017 12:03:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-09/txt/msg00619.txt.bz2 Content-length: 918 On 09/21/2017 12:27 PM, Tedeschi, Walfred wrote: > From: gdb-patches-owner@sourceware.org [mailto:gdb-patches-owner@sourceware.org] On Behalf Of Pedro Alves >> But I went ahead and took a quick look. I have to say that don't care for the "dwarf2utils" name much BTW. My issue with "utils.h|c" is that >"utils" is a kitchen sync name; almost anything can be called an "utility". And "dwarf2utils" has almost the same issue, in my view. Note that I >had suggested producers.h/c without a "dwarf" qualification because the producers string is exposed in generic code, through >symtab.h:compunit_symtab etc. >> (even though the producers info is currently only sourced from DWARF info). > My concern with the name was to create a file that could be used for more things, but not much more. > Do you consider a better approach to have a specialized file, having only the producers on it? Yes. Thanks, Pedro Alves