Re: [PATCH v2 4/5] gdb: generate the prefix name for prefix commands on demand

[Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>]

On 2021-03-08 6:25 p.m., Simon Marchi via Gdb-patches wrote:
> On 2021-01-25 6:26 a.m., Marco Barisione via Gdb-patches wrote:
>> Previously, the prefixname field of struct cmd_list_element was manually
>> set for prefix commands.  This seems verbose and error prone as it
>> required every single call to functions adding prefix commands to
>> specify the prefix name while the same information can be easily
>> generated.
>>
>> Historically, this was not possible as the prefix field was null for
>> many commands, but this was fixed in commit
>> 3f4d92ebdf7f848b5ccc9e8d8e8514c64fde1183 by Philippe Waroquiers, so
>> we can rely on the prefix field being set when generating the prefix
>> name.
> 
> Sounds like a good idea to me.  The patch is ok to push with these nits
> fixed.

Oh, one more thing, the patch doesn't build with --enable-targets=all.
Please configure your GDB build with --enable-targets=all and make sure
it builds.

There may also be some places that need to be updated in files that are
specific to some platforms.  That would be all the files that are
mentioned in gdb/configure.nat.  Please make a best effort to update the
calls in these files, even if you can't build them.

Simon