From: Marco Barisione via Gdb-patches <gdb-patches@sourceware.org>
To: gdb-patches@sourceware.org
Subject: [PATCH 0/4] Add support for command renaming
Date: Fri, 8 Jan 2021 10:07:02 +0000 [thread overview]
Message-ID: <20210108100706.96190-1-mbarisione@undo.io> (raw)
This patch series adds support for command renaming to GDB. The main
use case is to extend existing commands:
* The original command gets renamed.
* A new command with the same original name gets defined and then calls
the renamed one.
This feature is accessible via GDB commands ("rename" and
"define -rename-existing-to") and in Python via a new rename_existing_to
argument argument to gdb.Command.__init__.
This is the third attempt at achieving this, the first patch series (see
https://sourceware.org/legacy-ml/gdb-patches/2019-10/msg00985.html) used
a completely different approach where a command, once overwritten, was
preserved by the new command (via a new field in cmd_list_element).
Overwriting commands could access the original implementation via a
Python method on gdb.Command.
The second attempt (see
https://sourceware.org/pipermail/gdb-patches/2020-September/171829.html)
was a revised version of the previous one which worked in a similar way,
but using a slightly different terminology. It also added a way to
access this feature via a GDB command, not only via Python.
In response to my patches, Pedro Alves recommended a different approach
involving command renaming, which is what I implemented here.
Note that I didn't use "v3" in these patches are the approach is
completely different from previous attempts, so it's not really a new
version of already proposed patches (even if the end goal of this
feature is the same).
Marco Barisione (4):
gdb: add lookup_cmd_exact to simplify a common pattern
gdb: prevent prefix commands from being hooks
gdb: update the docs for add_cmd and do_add_cmd to match reality
gdb: Add support for renaming commands
gdb/NEWS | 26 +
gdb/cli/cli-decode.c | 708 +++++++++++++++---
gdb/cli/cli-decode.h | 3 +
gdb/cli/cli-script.c | 368 +++++++--
gdb/command.h | 103 ++-
gdb/doc/gdb.texinfo | 55 +-
gdb/doc/python.texi | 38 +-
gdb/python/py-cmd.c | 172 ++++-
gdb/testsuite/gdb.base/command-renaming.exp | 571 ++++++++++++++
gdb/testsuite/gdb.base/define-prefix.exp | 24 +
.../gdb.python/py-rename-existing.exp | 364 +++++++++
.../gdb.python/py-rename-existing.py | 46 ++
12 files changed, 2238 insertions(+), 240 deletions(-)
create mode 100644 gdb/testsuite/gdb.base/command-renaming.exp
create mode 100644 gdb/testsuite/gdb.python/py-rename-existing.exp
create mode 100644 gdb/testsuite/gdb.python/py-rename-existing.py
--
2.28.0
next reply other threads:[~2021-01-08 10:07 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-08 10:07 Marco Barisione via Gdb-patches [this message]
2021-01-08 10:07 ` [PATCH 1/4] gdb: add lookup_cmd_exact to simplify a common pattern Marco Barisione via Gdb-patches
2021-01-10 0:06 ` Lancelot SIX via Gdb-patches
2021-01-17 10:47 ` Marco Barisione via Gdb-patches
2021-01-17 19:02 ` Lancelot SIX via Gdb-patches
2021-01-25 11:33 ` Luis Machado via Gdb-patches
2021-01-08 10:07 ` [PATCH 2/4] gdb: prevent prefix commands from being hooks Marco Barisione via Gdb-patches
2021-01-08 10:07 ` [PATCH 3/4] gdb: update the docs for add_cmd and do_add_cmd to match reality Marco Barisione via Gdb-patches
2021-01-08 10:07 ` [PATCH 4/4] gdb: Add support for renaming commands Marco Barisione via Gdb-patches
2021-01-08 10:30 ` Eli Zaretskii via Gdb-patches
2021-01-25 11:26 ` [PATCH v2 0/5] Add support for command renaming Marco Barisione via Gdb-patches
2021-01-25 11:26 ` [PATCH v2 1/5] gdb: add lookup_cmd_exact to simplify a common pattern Marco Barisione via Gdb-patches
2021-03-08 18:58 ` Simon Marchi
2021-05-07 14:47 ` Marco Barisione via Gdb-patches
2021-01-25 11:26 ` [PATCH v2 2/5] gdb: prevent prefix commands from being hooks Marco Barisione via Gdb-patches
2021-03-08 21:32 ` Simon Marchi via Gdb-patches
2021-03-09 9:42 ` Marco Barisione via Gdb-patches
2021-03-16 3:17 ` Simon Marchi via Gdb-patches
2021-05-07 14:59 ` Marco Barisione via Gdb-patches
2021-05-07 19:30 ` Simon Marchi via Gdb-patches
2021-05-07 20:11 ` Marco Barisione via Gdb-patches
2021-05-14 20:38 ` [PATCH v3 " Marco Barisione via Gdb-patches
2021-01-25 11:26 ` [PATCH v2 3/5] gdb: update the docs for add_cmd and do_add_cmd to match reality Marco Barisione via Gdb-patches
2021-03-08 22:52 ` Simon Marchi via Gdb-patches
2021-03-08 23:10 ` Simon Marchi via Gdb-patches
2021-05-14 20:39 ` [PATCH v3 3/5] gdb: move declarations and docs for cli-decode.c to cli-decode.h Marco Barisione via Gdb-patches
2021-01-25 11:26 ` [PATCH v2 4/5] gdb: generate the prefix name for prefix commands on demand Marco Barisione via Gdb-patches
2021-03-08 23:25 ` Simon Marchi via Gdb-patches
2021-03-16 17:00 ` Simon Marchi via Gdb-patches
2021-05-12 11:10 ` Marco Barisione via Gdb-patches
2021-01-25 11:26 ` [PATCH v2 5/5] gdb: Add support for renaming commands Marco Barisione via Gdb-patches
2021-03-23 18:45 ` Simon Marchi via Gdb-patches
2021-05-14 20:41 ` [PATCH v3 5/5] gdb: add " Marco Barisione via Gdb-patches
2021-02-08 17:53 ` [PING] [PATCH v2 0/5] Add support for command renaming Marco Barisione via Gdb-patches
2021-02-15 8:27 ` [PING2] " Marco Barisione via Gdb-patches
2021-02-22 8:28 ` [PING 3] " Marco Barisione via Gdb-patches
2021-03-01 8:32 ` [PING 4] " Marco Barisione via Gdb-patches
2021-03-08 9:23 ` [PING 5] " Marco Barisione via Gdb-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210108100706.96190-1-mbarisione@undo.io \
--to=gdb-patches@sourceware.org \
--cc=mbarisione@undo.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox