Re: [PING 5] [PATCH v2 0/5] Add support for command renaming

[Marco Barisione via Gdb-patches <gdb-patches@sourceware.org>]

Ping 5.

On Mon, 1 Mar 2021 at 08:32, Marco Barisione <mbarisione@undo.io> wrote:
>
> Ping 4.
>
> On Mon, 22 Feb 2021 at 08:28, Marco Barisione <mbarisione@undo.io> wrote:
> >
> > Ping.
> >
> > > On 15 Feb 2021, at 08:27, Marco Barisione <mbarisione@undo.io> wrote:
> > >
> > > Ping.
> > >
> > > On Mon, 8 Feb 2021 at 17:53, Marco Barisione <mbarisione@undo.io> wrote:
> > >>
> > >> Ping.
> > >>
> > >> On Mon, 25 Jan 2021 at 11:26, Marco Barisione <mbarisione@undo.io> wrote:
> > >>> This patch series adds support for command renaming to GDB.  See the
> > >>> first email of this thread for details on the rationale and design.
> > >>>
> > >>> This second version fixes a few style issues, a bug in my code, and the
> > >>> way the prefix name for prefix commands is set.  In particular:
> > >>> * Patch 1: add lookup_cmd_exact to simplify a common pattern
> > >>>  Same as before except for style fixes.
> > >>> * Patch 2: prevent prefix commands from being hooks
> > >>>  Same as before.
> > >>> * Patch 3: update the docs for add_cmd and do_add_cmd to match reality
> > >>>  Same as before.
> > >>> * Patch 4: generate the prefix name for prefix commands on demand
> > >>>  New patch which changes how the prefix name is set/generated.
> > >>>  This simplifies a lot of existing code and the code from the next
> > >>>  patch.  Moreover, it fixes what I think could lead to a use after
> > >>>  free (based on reading code, I didn't actually reproduce any crash).
> > >>> * Patch 5: Add support for renaming commands
> > >>>  Updated version of what was before patch 4.
> > >>>  This contains a few style fixes and makes delete_cmd_by_name use
> > >>>  the lookup_cmd_exact function rather than find_cmd.
> > >>>
> > >>> Note that patches 1 to 4 are needed for the new feature but could be
> > >>> merged separately as they are improvements to the existing code.
> > >>>
> > >>> Marco Barisione (5):
> > >>>  gdb: add lookup_cmd_exact to simplify a common pattern
> > >>>  gdb: prevent prefix commands from being hooks
> > >>>  gdb: update the docs for add_cmd and do_add_cmd to match reality
> > >>>  gdb: generate the prefix name for prefix commands on demand
> > >>>  gdb: Add support for renaming commands
> > >>>
> > >>> gdb/NEWS                                      |  26 +
> > >>> gdb/ada-lang.c                                |   8 +-
> > >>> gdb/arm-tdep.c                                |   4 +-
> > >>> gdb/auto-load.c                               |   9 +-
> > >>> gdb/breakpoint.c                              |  20 +-
> > >>> gdb/bsd-kvm.c                                 |   2 +-
> > >>> gdb/btrace.c                                  |   9 +-
> > >>> gdb/cli/cli-cmds.c                            |  12 +-
> > >>> gdb/cli/cli-decode.c                          | 731 ++++++++++++++----
> > >>> gdb/cli/cli-decode.h                          |  29 +-
> > >>> gdb/cli/cli-dump.c                            |  16 +-
> > >>> gdb/cli/cli-logging.c                         |   4 +-
> > >>> gdb/cli/cli-script.c                          | 375 +++++++--
> > >>> gdb/cli/cli-setshow.c                         |  11 +-
> > >>> gdb/cli/cli-style.c                           |  11 +-
> > >>> gdb/cli/cli-style.h                           |   3 -
> > >>> gdb/command.h                                 | 110 ++-
> > >>> gdb/compile/compile.c                         |   2 +-
> > >>> gdb/cp-support.c                              |   1 -
> > >>> gdb/dcache.c                                  |   5 +-
> > >>> gdb/doc/gdb.texinfo                           |  55 +-
> > >>> gdb/doc/python.texi                           |  38 +-
> > >>> gdb/dwarf2/index-cache.c                      |   4 +-
> > >>> gdb/dwarf2/read.c                             |   4 +-
> > >>> gdb/f-lang.c                                  |   4 +-
> > >>> gdb/frame.c                                   |   4 +-
> > >>> gdb/gnu-nat.c                                 |  12 +-
> > >>> gdb/go32-nat.c                                |   2 +-
> > >>> gdb/guile/guile.c                             |   9 +-
> > >>> gdb/guile/scm-cmd.c                           |   2 +-
> > >>> gdb/i386-tdep.c                               |   4 +-
> > >>> gdb/infcmd.c                                  |   8 +-
> > >>> gdb/language.c                                |   4 +-
> > >>> gdb/macrocmd.c                                |   2 +-
> > >>> gdb/maint-test-options.c                      |   3 +-
> > >>> gdb/maint-test-settings.c                     |   2 -
> > >>> gdb/maint.c                                   |  18 +-
> > >>> gdb/memattr.c                                 |   4 +-
> > >>> gdb/mips-tdep.c                               |   6 +-
> > >>> gdb/printcmd.c                                |   2 +-
> > >>> gdb/probe.c                                   |   3 +-
> > >>> gdb/python/py-cmd.c                           | 228 ++++--
> > >>> gdb/python/python-internal.h                  |   1 +
> > >>> gdb/python/python.c                           |   6 +-
> > >>> gdb/ravenscar-thread.c                        |   4 +-
> > >>> gdb/record-btrace.c                           |  16 +-
> > >>> gdb/record-full.c                             |   6 +-
> > >>> gdb/record.c                                  |  10 +-
> > >>> gdb/remote.c                                  |   6 +-
> > >>> gdb/riscv-tdep.c                              |   8 +-
> > >>> gdb/rs6000-tdep.c                             |   4 +-
> > >>> gdb/ser-tcp.c                                 |   4 +-
> > >>> gdb/serial.c                                  |   4 +-
> > >>> gdb/sh-tdep.c                                 |   4 +-
> > >>> gdb/skip.c                                    |   2 +-
> > >>> gdb/sparc64-tdep.c                            |   2 +-
> > >>> gdb/stack.c                                   |   8 +-
> > >>> gdb/symfile.c                                 |   2 +-
> > >>> gdb/symtab.c                                  |   3 +-
> > >>> gdb/target-descriptions.c                     |   6 +-
> > >>> gdb/target.c                                  |   2 +-
> > >>> gdb/testsuite/gdb.base/command-renaming.exp   | 571 ++++++++++++++
> > >>> gdb/testsuite/gdb.base/define-prefix.exp      |  24 +
> > >>> .../gdb.python/py-rename-existing.exp         | 364 +++++++++
> > >>> .../gdb.python/py-rename-existing.py          |  46 ++
> > >>> gdb/thread.c                                  |   4 +-
> > >>> gdb/top.c                                     |  10 +-
> > >>> gdb/tracepoint.c                              |   2 +-
> > >>> gdb/tui/tui-layout.c                          |   2 +-
> > >>> gdb/tui/tui-win.c                             |   8 +-
> > >>> gdb/typeprint.c                               |   6 +-
> > >>> gdb/unittests/command-def-selftests.c         |   4 +-
> > >>> gdb/utils.c                                   |   4 -
> > >>> gdb/valprint.c                                |  10 +-
> > >>> gdb/value.c                                   |   2 +-
> > >>> gdb/windows-tdep.c                            |   2 +-
> > >>> 76 files changed, 2434 insertions(+), 529 deletions(-)
> > >>> create mode 100644 gdb/testsuite/gdb.base/command-renaming.exp
> > >>> create mode 100644 gdb/testsuite/gdb.python/py-rename-existing.exp
> > >>> create mode 100644 gdb/testsuite/gdb.python/py-rename-existing.py
> > >>>
> > >>> --
> > >>> 2.28.0
> > >>>
> >
> > --
> > Marco Barisione
> >