Re: [PATCH v2 4/5] gdb: generate the prefix name for prefix commands on demand

[Marco Barisione via Gdb-patches <gdb-patches@sourceware.org>]

On Mon, 8 Mar 2021 at 23:25, Simon Marchi <simon.marchi@polymtl.ca> wrote:
> On 2021-01-25 6:26 a.m., Marco Barisione via Gdb-patches wrote:
> > Previously, the prefixname field of struct cmd_list_element was manually
> > set for prefix commands.  This seems verbose and error prone as it
> > required every single call to functions adding prefix commands to
> > specify the prefix name while the same information can be easily
> > generated.
> >
> > Historically, this was not possible as the prefix field was null for
> > many commands, but this was fixed in commit
> > 3f4d92ebdf7f848b5ccc9e8d8e8514c64fde1183 by Philippe Waroquiers, so
> > we can rely on the prefix field being set when generating the prefix
> > name.
>
> Sounds like a good idea to me.  The patch is ok to push with these nits
> fixed.

I fixed the nits, fixed the two commands I previously forgot to update
(maintenance print arc and memory-tag), and manually double checked
all the calls to add_prefix and friends.

This is now pushed (2f822da535ba9b159174d02d7114b4fc4f7c8818).

> > gdb/ChangeLog:
> >
> > [...]
> >       * arm-tdep.c (_initialize_arm_tdep): Ditto.
> >       * auto-load.c: Ditto.
> >       * breakpoint.c: Ditto.
> >       * bsd-kvm.c: Ditto.
> >       * btrace.c: Ditto.
> >       * cli/cli-cmds.c: Ditto.
> >       * cli/cli-dump.c (_initialize_cli_dump): Ditto.
> >  [...]
>
> IMO it's not really useful to list all the spots that were just
> trivially adjusted.  It's ok to write things like:
>
>   * command.h (add_prefix_cmd): Remove prefixname parameter.  Update all
>   callers.
>
> ... and then skip listing all callers.  That will also help preserve
> your sanity.

I thought I had to list everything but glad to know I don't!

-- 
Marco Barisione