Re: [PATCH v2 1/5] gdb: add lookup_cmd_exact to simplify a common pattern

[Marco Barisione via Gdb-patches <gdb-patches@sourceware.org>]

On Mon, 8 Mar 2021 at 18:58, Simon Marchi <simark@simark.ca> wrote:
>
> On 2021-01-25 6:26 a.m., Marco Barisione via Gdb-patches wrote:
> > In code dealing with commands, there's a pattern repeated a few times of
> > calling lookup_cmd with some speficic arguments and then using strcmp
> > on the returned command to check for an exact match.
> > As a later patch would add a few more similar lines of code, this patch
> > adds a new lookup_cmd_exact function which simplify this use case.
> >
> > gdb/ChangeLog:
> >
> >       * cli/cli-decode.c (lookup_cmd_exact): Add.
> >       * cli/cli-script.c (do_define_command): Use lookup_cmd_exact.
> >       (define_prefix_command): Ditto.
> >       * command.h: Add lookup_cmd_exact.
>
> This is ok, you can push it on its own right away, as it's a good
> cleanup on its own.

Thanks for your reviews!
This is now pushed to master (a9b49cbcd5935a713da5715799ea3b24e0a52851).

Sorry for taking a while, but I had to work on some other things.
I will now follow up on this patch series to address your review comments.

-- 
Marco Barisione