Re: [PATCH] Use the "O!" format more in the Python code

[Tom de Vries <tdevries@suse.de>]

On 2/27/26 5:48 PM, Tom Tromey wrote:
> -  if (!PyArg_ParseTuple (args, "O", &parse_obj))
> +  if (!PyArg_ParseTuple (args, "O!", &recpy_insn_type, &parse_obj))
>       return NULL;
>   
> -  if (Py_TYPE (parse_obj) != &recpy_insn_type)
> -    return PyErr_Format (PyExc_TypeError, _("Argument must be instruction."));

Hi,

I reviewed this patch, and LGTM.

Reviewed-By: Tom de Vries <tdevries@suse.de>

I asked an AI to review this as well, and it mentioned that the piece of 
code above slightly changes semantics because using 'O!' also allows 
subclasses.

I saw other direct comparisons to recpy_insn_type in the code, and 
wondered if those should likewise allow subclasses using PyObject_TypeCheck.

But I suppose we just assume there are no subclasses?

Thanks,
- Tom