From: Tom Tromey <tom@tromey.com>
To: Tom Tromey <tom@tromey.com>
Cc: Tom de Vries <tdevries@suse.de>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Use the "O!" format more in the Python code
Date: Fri, 27 Feb 2026 12:01:49 -0700 [thread overview]
Message-ID: <875x7it3he.fsf@tromey.com> (raw)
In-Reply-To: <87qzq6t4vy.fsf@tromey.com> (Tom Tromey's message of "Fri, 27 Feb 2026 11:31:29 -0700")
>>>>> "Tom" == Tom Tromey <tom@tromey.com> writes:
>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
Tom> I saw other direct comparisons to recpy_insn_type in the code, and
Tom> wondered if those should likewise allow subclasses using
Tom> PyObject_TypeCheck.
Tom> But I suppose we just assume there are no subclasses?
> I'm not sure if you can subclass an instruction type (I thought perhaps
> we needed special code in the type definition to support subclassing),
> but if you can, then it should be usable here.
I answered this backward somehow!?
Yeah, if subclasses are at all possible then the other spots should be
updated.
Tom
next prev parent reply other threads:[~2026-02-27 19:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-27 16:48 Tom Tromey
2026-02-27 18:23 ` Tom de Vries
2026-02-27 18:31 ` Tom Tromey
2026-02-27 19:01 ` Tom Tromey [this message]
2026-02-27 19:06 ` Tom de Vries
2026-02-27 19:35 ` Paul Koning
2026-02-27 19:58 ` Tom Tromey
2026-02-27 20:24 ` Paul Koning
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875x7it3he.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox