Re: [PATCH] Use the "O!" format more in the Python code

[Paul Koning <paulkoning@comcast.net>]

> On Feb 27, 2026, at 1:31 PM, Tom Tromey <tom@tromey.com> wrote:
> 
>>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
> 
> Tom> I saw other direct comparisons to recpy_insn_type in the code, and
> Tom> wondered if those should likewise allow subclasses using
> Tom> PyObject_TypeCheck.
> 
> Tom> But I suppose we just assume there are no subclasses?
> 
> I'm not sure if you can subclass an instruction type (I thought perhaps
> we needed special code in the type definition to support subclassing),
> but if you can, then it should be usable here.
> 
> Tom

Agreed.  The Python Way is that subclasses of a type can be used where a given type is expected.  Also, any type can be subclassed.  That last point is not true for types defined in C code, unless the code allows it to happen.  In general it should do so; it's very rare indeed for it to be "the right thing" for a type not to allow subclasses.

	paul