Re: [PATCH] Use the "O!" format more in the Python code

[Tom de Vries <tdevries@suse.de>]

On 2/27/26 8:01 PM, Tom Tromey wrote:
>>>>>> "Tom" == Tom Tromey <tom@tromey.com> writes:
> 
>>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
> Tom> I saw other direct comparisons to recpy_insn_type in the code, and
> Tom> wondered if those should likewise allow subclasses using
> Tom> PyObject_TypeCheck.
> 
> Tom> But I suppose we just assume there are no subclasses?
> 
>> I'm not sure if you can subclass an instruction type (I thought perhaps
>> we needed special code in the type definition to support subclassing),
>> but if you can, then it should be usable here.
> 
> I answered this backward somehow!?
> 
> Yeah, if subclasses are at all possible then the other spots should be
> updated.
I found this ( 
https://docs.python.org/3/c-api/typeobj.html#c.PyTypeObject.tp_subclasses 
), so I suppose unless tp_subclasses is set somehow in the type 
definition, there are no subclasses, and that's the case for 
recpy_insn_type.

So there's no direct need to update those other spots, but OTOH it can't 
hurt I suppose.

Thanks,
- Tom