From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id YQWrF2/hoWmD0AwAWB0awg (envelope-from ) for ; Fri, 27 Feb 2026 13:24:47 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=vpxAtAHd; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=IP3uT3k1; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=vpxAtAHd; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=IP3uT3k1; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 5966D1E0DD; Fri, 27 Feb 2026 13:24:47 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 547111E089 for ; Fri, 27 Feb 2026 13:24:46 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id D7C0D4BA2E1A for ; Fri, 27 Feb 2026 18:24:45 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D7C0D4BA2E1A Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=vpxAtAHd; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=IP3uT3k1; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=vpxAtAHd; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=IP3uT3k1 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by sourceware.org (Postfix) with ESMTPS id 510064BA23C5 for ; Fri, 27 Feb 2026 18:23:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 510064BA23C5 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 510064BA23C5 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1772216585; cv=none; b=ot3lKmIlCcNjLRYr+uN47+eUaNt30bofSEUcI1LswlMSJPuJg1VMTkHcxocuUzS25FY6occ1nfUBCvg9J7ttpjFtu5umgQiOXELUOiQ6pGQEnRLSwAGGJzShHUTmu8Lsak4XAsXL1sqhjua8NvMC9KEy0Yu6xAL1e/UEWrRq8BY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1772216585; c=relaxed/simple; bh=Hq8qQWyvd1eImWfS1ojaX9FVRwx5ZxWX0j8SRBwC+68=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=mUFN+L+OD7AlpRp6yN7pb/sI8hDJMWCaM79qhZr+vh98Cn9yXfyCiSbVEhO9heKq8CXzit1bC7xxIAf8OGWxyfMYns6gxbqvBQuHpWsNJWXFOSwOkeWkOkXdi/AniXSKK+mc2PmfgBW8lyc8Y23yL4kwcImYRGCTR6pj6ncNYfE= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 510064BA23C5 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 438521FAD4; Fri, 27 Feb 2026 18:23:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1772216584; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UhZ8YRONAGKEsWAgsomDOaAOCfrK52LdLBHdtZhIn8o=; b=vpxAtAHdouTM/+BvRQ8nSTKbN6gMRa8kGUyaPaI9ZgcbVCHN9nHAIrF0tozQL1hxlIdxBa V8W+yMFUkb04PzhjEZFI96WqQX9X8MKYzgO1KkaUQQP6+dXsc7U+5FlTrnU1SidPRA0yPa 3EBe2y4KxqkCq7Xigdl5pUJD4WJ5NbI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1772216584; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UhZ8YRONAGKEsWAgsomDOaAOCfrK52LdLBHdtZhIn8o=; b=IP3uT3k1MPzrPUzdcolZdJmeWzHCPGua495XToewJB4Y1mJcDHqsQoXv8MUqLWOyLP92DX zNpLS6YLNfncVBBA== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=vpxAtAHd; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=IP3uT3k1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1772216584; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UhZ8YRONAGKEsWAgsomDOaAOCfrK52LdLBHdtZhIn8o=; b=vpxAtAHdouTM/+BvRQ8nSTKbN6gMRa8kGUyaPaI9ZgcbVCHN9nHAIrF0tozQL1hxlIdxBa V8W+yMFUkb04PzhjEZFI96WqQX9X8MKYzgO1KkaUQQP6+dXsc7U+5FlTrnU1SidPRA0yPa 3EBe2y4KxqkCq7Xigdl5pUJD4WJ5NbI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1772216584; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UhZ8YRONAGKEsWAgsomDOaAOCfrK52LdLBHdtZhIn8o=; b=IP3uT3k1MPzrPUzdcolZdJmeWzHCPGua495XToewJB4Y1mJcDHqsQoXv8MUqLWOyLP92DX zNpLS6YLNfncVBBA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 2DE233EA69; Fri, 27 Feb 2026 18:23:04 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id JEGeCQjhoWk8bQAAD6G6ig (envelope-from ); Fri, 27 Feb 2026 18:23:04 +0000 Message-ID: Date: Fri, 27 Feb 2026 19:23:03 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] Use the "O!" format more in the Python code To: Tom Tromey , gdb-patches@sourceware.org References: <20260227164843.2275912-1-tom@tromey.com> Content-Language: en-US From: Tom de Vries In-Reply-To: <20260227164843.2275912-1-tom@tromey.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-0.999]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; SUBJECT_HAS_EXCLAIM(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; ARC_NA(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; MIME_TRACE(0.00)[0:+]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; TO_DN_SOME(0.00)[]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:104:10:150:64:97:from,2a07:de40:b281:106:10:150:64:167:received]; RCVD_VIA_SMTP_AUTH(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; DKIM_TRACE(0.00)[suse.de:+]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo, imap1.dmz-prg2.suse.org:rdns, suse.de:mid, suse.de:dkim, suse.de:email] X-Rspamd-Action: no action X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Rspamd-Queue-Id: 438521FAD4 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 2/27/26 5:48 PM, Tom Tromey wrote: > - if (!PyArg_ParseTuple (args, "O", &parse_obj)) > + if (!PyArg_ParseTuple (args, "O!", &recpy_insn_type, &parse_obj)) > return NULL; > > - if (Py_TYPE (parse_obj) != &recpy_insn_type) > - return PyErr_Format (PyExc_TypeError, _("Argument must be instruction.")); Hi, I reviewed this patch, and LGTM. Reviewed-By: Tom de Vries I asked an AI to review this as well, and it mentioned that the piece of code above slightly changes semantics because using 'O!' also allows subclasses. I saw other direct comparisons to recpy_insn_type in the code, and wondered if those should likewise allow subclasses using PyObject_TypeCheck. But I suppose we just assume there are no subclasses? Thanks, - Tom