Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Simon Marchi <simark@simark.ca>
To: gdb-patches@sourceware.org,
	Thomas Schwinge <thomas@codesourcery.com>,
	thomas@schwinge.name, bug-hurd@gnu.org
Subject: Re: [PATCHv2 5/7] hurd: remove unused variables
Date: Sat, 30 May 2020 10:49:03 -0400	[thread overview]
Message-ID: <c2837171-2722-a511-2fbf-db69449860f2@simark.ca> (raw)
In-Reply-To: <20200529220318.xh6ke7brt45bm5ed@function>

On 2020-05-29 6:03 p.m., Samuel Thibault wrote:
> Fixes
> 
> ../../gdb/gnu-nat.c:2554:7: error: unused variable ‘res’ [-Werror=unused-variable]
>  2554 |   int res;
> ../../gdb/gnu-nat.c:2644:20: error: unused variable ‘old_address’ [-Werror=unused-variable]
>  2644 |       vm_address_t old_address = region_address;
> 
> gdb/ChangeLog:
> 
> 2020-05-29  Samuel Thibault  <samuel.thibault@ens-lyon.org>
> 
> 	* gnu-nat.c (gnu_xfer_auxv): Remove unused `res' variable.
> 	(gnu_nat_target::find_memory_regions): Remove unused
> 	`old_address' variable.
> 
> diff --git a/gdb/gnu-nat.c b/gdb/gnu-nat.c
> index 3b438a9a43..78e9ab7f71 100644
> --- a/gdb/gnu-nat.c
> +++ b/gdb/gnu-nat.c
> @@ -2551,7 +2554,6 @@ gnu_xfer_auxv (gdb_byte *readbuf, const gdb_byte *writebuf,
>  		    ? gnu_current_inf->task->port : 0)
>  		 : 0);
>    process_t proc;
> -  int res;
>    kern_return_t err;
>    vm_address_t entry;
>    ElfW(auxv_t) auxv[2];
> @@ -2641,7 +2643,6 @@ gnu_nat_target::find_memory_regions (find_memory_region_ftype func,
>        mach_port_t object_name;
>        vm_offset_t offset;
>        vm_size_t region_length = VM_MAX_ADDRESS - region_address;
> -      vm_address_t old_address = region_address;
>  
>        err = vm_region (task,
>  		       &region_address,
> 

Thanks, this is ok.

Simon


  reply	other threads:[~2020-05-30 14:49 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-29 22:00 [PATCHv2 1/7] hurd: fix gnu_debug_flag type Samuel Thibault
2020-05-29 22:01 ` [PATCHv2 2/7] hurd: add missing awk script dependency Samuel Thibault
2020-05-30 14:42   ` Simon Marchi
2020-05-29 22:01 ` [PATCHv2 3/7] hurd: make function cast stronger Samuel Thibault
2020-05-30 14:47   ` Simon Marchi
2020-05-30 15:32     ` Samuel Thibault
2020-05-30 16:02       ` Simon Marchi
2020-05-29 22:02 ` [PATCHv2 4/7] hurd: add missing include Samuel Thibault
2020-05-30 14:48   ` Simon Marchi
2020-05-29 22:03 ` [PATCHv2 5/7] hurd: remove unused variables Samuel Thibault
2020-05-30 14:49   ` Simon Marchi [this message]
2020-05-29 22:03 ` [PATCHv2 6/7] hurd: add gnu_target pointer to fix thread API calls Samuel Thibault
2020-05-30 14:57   ` Simon Marchi
2020-05-30 15:53     ` Samuel Thibault
2020-05-30 16:08       ` Simon Marchi
2020-05-30 17:22         ` Samuel Thibault
2020-05-29 22:04 ` [PATCHv2 7/7] hurd: fix pushing target on inferior creation Samuel Thibault
2020-05-30 15:01   ` Simon Marchi
2020-05-30 14:39 ` [PATCHv2 1/7] hurd: fix gnu_debug_flag type Simon Marchi
2020-05-30 16:00   ` Samuel Thibault
2020-05-30 16:12     ` Simon Marchi
2020-05-30 16:53       ` Samuel Thibault
2020-05-30 17:38         ` Simon Marchi
2020-05-30 19:07 ` Samuel Thibault

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c2837171-2722-a511-2fbf-db69449860f2@simark.ca \
    --to=simark@simark.ca \
    --cc=bug-hurd@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=thomas@codesourcery.com \
    --cc=thomas@schwinge.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox