From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 5D14C3858D35 for ; Sat, 30 May 2020 14:49:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 5D14C3858D35 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca Received: from [10.0.0.11] (173-246-6-90.qc.cable.ebox.net [173.246.6.90]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id B41F11E791; Sat, 30 May 2020 10:49:03 -0400 (EDT) Subject: Re: [PATCHv2 5/7] hurd: remove unused variables To: gdb-patches@sourceware.org, Thomas Schwinge , thomas@schwinge.name, bug-hurd@gnu.org References: <20200529220049.gm7vt7gvtw7if6lg@function> <20200529220318.xh6ke7brt45bm5ed@function> From: Simon Marchi Message-ID: Date: Sat, 30 May 2020 10:49:03 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <20200529220318.xh6ke7brt45bm5ed@function> Content-Type: text/plain; charset=utf-8 Content-Language: fr Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-9.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 30 May 2020 14:49:05 -0000 On 2020-05-29 6:03 p.m., Samuel Thibault wrote: > Fixes > > ../../gdb/gnu-nat.c:2554:7: error: unused variable ‘res’ [-Werror=unused-variable] > 2554 | int res; > ../../gdb/gnu-nat.c:2644:20: error: unused variable ‘old_address’ [-Werror=unused-variable] > 2644 | vm_address_t old_address = region_address; > > gdb/ChangeLog: > > 2020-05-29 Samuel Thibault > > * gnu-nat.c (gnu_xfer_auxv): Remove unused `res' variable. > (gnu_nat_target::find_memory_regions): Remove unused > `old_address' variable. > > diff --git a/gdb/gnu-nat.c b/gdb/gnu-nat.c > index 3b438a9a43..78e9ab7f71 100644 > --- a/gdb/gnu-nat.c > +++ b/gdb/gnu-nat.c > @@ -2551,7 +2554,6 @@ gnu_xfer_auxv (gdb_byte *readbuf, const gdb_byte *writebuf, > ? gnu_current_inf->task->port : 0) > : 0); > process_t proc; > - int res; > kern_return_t err; > vm_address_t entry; > ElfW(auxv_t) auxv[2]; > @@ -2641,7 +2643,6 @@ gnu_nat_target::find_memory_regions (find_memory_region_ftype func, > mach_port_t object_name; > vm_offset_t offset; > vm_size_t region_length = VM_MAX_ADDRESS - region_address; > - vm_address_t old_address = region_address; > > err = vm_region (task, > ®ion_address, > Thanks, this is ok. Simon