From: Simon Marchi <simark@simark.ca>
To: gdb-patches@sourceware.org,
Thomas Schwinge <thomas@codesourcery.com>,
thomas@schwinge.name, bug-hurd@gnu.org
Subject: Re: [PATCHv2 3/7] hurd: make function cast stronger
Date: Sat, 30 May 2020 10:47:50 -0400 [thread overview]
Message-ID: <faec1b93-edcd-3868-cbff-98524b67246e@simark.ca> (raw)
In-Reply-To: <20200529220153.63gej54cam7itzmk@function>
On 2020-05-29 6:01 p.m., Samuel Thibault wrote:
> Fixes
>
> process_reply_S.c:104:23: error: function called through a non-compatible type [-Werror]
> 104 | OutP->RetCode = (*(kern_return_t (*)(mach_port_t, kern_return_t)) S_proc_setmsgport_reply) (In0P->Head.msgh_request_port, In0P-
>
> gdb/ChangeLog:
>
> 2020-05-29 Samuel Thibault <samuel.thibault@ens-lyon.org>
>
> * reply_mig_hack.awk (Error return): Cast function through
> void *, to bypass compiler function call check.
If you are silencing a compiler warning, please explain why it is safe to do so. Why
are we calling a function in a non-compatible way, is it a warning false positive?
Because just like that, it just sounds like we are passing the wrong arguments and it
should not be fixed by just silencing the warning, but by fixing the call.
Simon
next prev parent reply other threads:[~2020-05-30 14:47 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-29 22:00 [PATCHv2 1/7] hurd: fix gnu_debug_flag type Samuel Thibault
2020-05-29 22:01 ` [PATCHv2 2/7] hurd: add missing awk script dependency Samuel Thibault
2020-05-30 14:42 ` Simon Marchi
2020-05-29 22:01 ` [PATCHv2 3/7] hurd: make function cast stronger Samuel Thibault
2020-05-30 14:47 ` Simon Marchi [this message]
2020-05-30 15:32 ` Samuel Thibault
2020-05-30 16:02 ` Simon Marchi
2020-05-29 22:02 ` [PATCHv2 4/7] hurd: add missing include Samuel Thibault
2020-05-30 14:48 ` Simon Marchi
2020-05-29 22:03 ` [PATCHv2 5/7] hurd: remove unused variables Samuel Thibault
2020-05-30 14:49 ` Simon Marchi
2020-05-29 22:03 ` [PATCHv2 6/7] hurd: add gnu_target pointer to fix thread API calls Samuel Thibault
2020-05-30 14:57 ` Simon Marchi
2020-05-30 15:53 ` Samuel Thibault
2020-05-30 16:08 ` Simon Marchi
2020-05-30 17:22 ` Samuel Thibault
2020-05-29 22:04 ` [PATCHv2 7/7] hurd: fix pushing target on inferior creation Samuel Thibault
2020-05-30 15:01 ` Simon Marchi
2020-05-30 14:39 ` [PATCHv2 1/7] hurd: fix gnu_debug_flag type Simon Marchi
2020-05-30 16:00 ` Samuel Thibault
2020-05-30 16:12 ` Simon Marchi
2020-05-30 16:53 ` Samuel Thibault
2020-05-30 17:38 ` Simon Marchi
2020-05-30 19:07 ` Samuel Thibault
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=faec1b93-edcd-3868-cbff-98524b67246e@simark.ca \
--to=simark@simark.ca \
--cc=bug-hurd@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=thomas@codesourcery.com \
--cc=thomas@schwinge.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox