From: Samuel Thibault <samuel.thibault@gnu.org>
To: Simon Marchi <simark@simark.ca>
Cc: gdb-patches@sourceware.org,
Thomas Schwinge <thomas@codesourcery.com>,
thomas@schwinge.name, bug-hurd@gnu.org
Subject: Re: [PATCHv2 1/7] hurd: fix gnu_debug_flag type
Date: Sat, 30 May 2020 18:00:37 +0200 [thread overview]
Message-ID: <20200530160037.fj7mohmused2qhne@function> (raw)
In-Reply-To: <995a0223-b69b-0998-df9e-c83c54673fa1@simark.ca>
Simon Marchi, le sam. 30 mai 2020 10:39:19 -0400, a ecrit:
> On 2020-05-29 6:00 p.m., Samuel Thibault wrote:
> > Fixes
> >
> > ../../gdb/gnu-nat.c:96:6: error: conflicting declaration ‘bool gnu_debug_flag’
> > 96 | bool gnu_debug_flag = false;
> > ../../gdb/gnu-nat.c: In function ‘void _initialize_gnu_nat()’:
> > ../../gdb/gnu-nat.c:3511:7: error: cannot
> >
> > gdb/ChangeLog:
> >
> > 2020-05-29 Samuel Thibault <samuel.thibault@ens-lyon.org>
> >
> > * gnu-nat.h (gnu_debug_flag): Set type to bool.
> >
> > diff --git a/gdb/gnu-nat.h b/gdb/gnu-nat.h
> > index 77c57817b2..7c36778394 100644
> > --- a/gdb/gnu-nat.h
> > +++ b/gdb/gnu-nat.h
> > @@ -111,7 +111,7 @@ extern char *proc_string (struct proc *proc);
> > __proc_pid (__proc), __proc->tid, \
> > host_address_to_string (__proc) , ##args); } while (0)
> >
> > -extern int gnu_debug_flag;
> > +extern bool gnu_debug_flag;
> >
> > #define debug(msg, args...) \
> > do { if (gnu_debug_flag) \
> >
>
> Thanks, this is OK.
Just to be sure, I don't have commit access so can't commit myself.
I didn't see that case documented on
https://sourceware.org/gdb/wiki/ContributionChecklist
linked from
https://www.gnu.org/software/gdb/contribute/
Samuel
next prev parent reply other threads:[~2020-05-30 16:00 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-29 22:00 Samuel Thibault
2020-05-29 22:01 ` [PATCHv2 2/7] hurd: add missing awk script dependency Samuel Thibault
2020-05-30 14:42 ` Simon Marchi
2020-05-29 22:01 ` [PATCHv2 3/7] hurd: make function cast stronger Samuel Thibault
2020-05-30 14:47 ` Simon Marchi
2020-05-30 15:32 ` Samuel Thibault
2020-05-30 16:02 ` Simon Marchi
2020-05-29 22:02 ` [PATCHv2 4/7] hurd: add missing include Samuel Thibault
2020-05-30 14:48 ` Simon Marchi
2020-05-29 22:03 ` [PATCHv2 5/7] hurd: remove unused variables Samuel Thibault
2020-05-30 14:49 ` Simon Marchi
2020-05-29 22:03 ` [PATCHv2 6/7] hurd: add gnu_target pointer to fix thread API calls Samuel Thibault
2020-05-30 14:57 ` Simon Marchi
2020-05-30 15:53 ` Samuel Thibault
2020-05-30 16:08 ` Simon Marchi
2020-05-30 17:22 ` Samuel Thibault
2020-05-29 22:04 ` [PATCHv2 7/7] hurd: fix pushing target on inferior creation Samuel Thibault
2020-05-30 15:01 ` Simon Marchi
2020-05-30 14:39 ` [PATCHv2 1/7] hurd: fix gnu_debug_flag type Simon Marchi
2020-05-30 16:00 ` Samuel Thibault [this message]
2020-05-30 16:12 ` Simon Marchi
2020-05-30 16:53 ` Samuel Thibault
2020-05-30 17:38 ` Simon Marchi
2020-05-30 19:07 ` Samuel Thibault
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200530160037.fj7mohmused2qhne@function \
--to=samuel.thibault@gnu.org \
--cc=bug-hurd@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=simark@simark.ca \
--cc=thomas@codesourcery.com \
--cc=thomas@schwinge.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox