From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from hera.aquilenet.fr (hera.aquilenet.fr [185.233.100.1]) by sourceware.org (Postfix) with ESMTPS id F209E3870909 for ; Sat, 30 May 2020 16:00:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org F209E3870909 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=samuel.thibault@gnu.org Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id D0DD246BE; Sat, 30 May 2020 18:00:39 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ZAwmoqOdPdMl; Sat, 30 May 2020 18:00:38 +0200 (CEST) Received: from function (lfbn-bor-1-797-11.w86-234.abo.wanadoo.fr [86.234.239.11]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 3B3753E6E; Sat, 30 May 2020 18:00:38 +0200 (CEST) Received: from samy by function with local (Exim 4.93) (envelope-from ) id 1jf3uX-00A8Mw-7j; Sat, 30 May 2020 18:00:37 +0200 Date: Sat, 30 May 2020 18:00:37 +0200 From: Samuel Thibault To: Simon Marchi Cc: gdb-patches@sourceware.org, Thomas Schwinge , thomas@schwinge.name, bug-hurd@gnu.org Subject: Re: [PATCHv2 1/7] hurd: fix gnu_debug_flag type Message-ID: <20200530160037.fj7mohmused2qhne@function> Mail-Followup-To: Simon Marchi , gdb-patches@sourceware.org, Thomas Schwinge , thomas@schwinge.name, bug-hurd@gnu.org References: <20200529220049.gm7vt7gvtw7if6lg@function> <995a0223-b69b-0998-df9e-c83c54673fa1@simark.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <995a0223-b69b-0998-df9e-c83c54673fa1@simark.ca> Organization: I am not organized User-Agent: NeoMutt/20170609 (1.8.3) X-Spam-Status: No, score=-10.4 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, KAM_SHORT, SPF_HELO_PASS, SPF_SOFTFAIL, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 30 May 2020 16:00:42 -0000 Simon Marchi, le sam. 30 mai 2020 10:39:19 -0400, a ecrit: > On 2020-05-29 6:00 p.m., Samuel Thibault wrote: > > Fixes > > > > ../../gdb/gnu-nat.c:96:6: error: conflicting declaration ‘bool gnu_debug_flag’ > > 96 | bool gnu_debug_flag = false; > > ../../gdb/gnu-nat.c: In function ‘void _initialize_gnu_nat()’: > > ../../gdb/gnu-nat.c:3511:7: error: cannot > > > > gdb/ChangeLog: > > > > 2020-05-29 Samuel Thibault > > > > * gnu-nat.h (gnu_debug_flag): Set type to bool. > > > > diff --git a/gdb/gnu-nat.h b/gdb/gnu-nat.h > > index 77c57817b2..7c36778394 100644 > > --- a/gdb/gnu-nat.h > > +++ b/gdb/gnu-nat.h > > @@ -111,7 +111,7 @@ extern char *proc_string (struct proc *proc); > > __proc_pid (__proc), __proc->tid, \ > > host_address_to_string (__proc) , ##args); } while (0) > > > > -extern int gnu_debug_flag; > > +extern bool gnu_debug_flag; > > > > #define debug(msg, args...) \ > > do { if (gnu_debug_flag) \ > > > > Thanks, this is OK. Just to be sure, I don't have commit access so can't commit myself. I didn't see that case documented on https://sourceware.org/gdb/wiki/ContributionChecklist linked from https://www.gnu.org/software/gdb/contribute/ Samuel