From: Simon Marchi <simark@simark.ca>
To: gdb-patches@sourceware.org,
Thomas Schwinge <thomas@codesourcery.com>,
thomas@schwinge.name, bug-hurd@gnu.org
Subject: Re: [PATCHv2 2/7] hurd: add missing awk script dependency
Date: Sat, 30 May 2020 10:42:54 -0400 [thread overview]
Message-ID: <48a2aaf3-8272-0ee5-758d-5ed5c78dfee9@simark.ca> (raw)
In-Reply-To: <20200529220123.nrbzpl7umpribknw@function>
On 2020-05-29 6:01 p.m., Samuel Thibault wrote:
> gdb/ChangeLog:
>
> 2020-05-29 Samuel Thibault <samuel.thibault@ens-lyon.org>
>
> * config/i386/i386gnu.mn (%_reply_S.c): Add dependency on
> $(srcdir)/reply_mig_hack.awk.
>
> diff --git a/gdb/config/i386/i386gnu.mn b/gdb/config/i386/i386gnu.mn
> index 1c3453823d..5c81efd007 100644
> --- a/gdb/config/i386/i386gnu.mn
> +++ b/gdb/config/i386/i386gnu.mn
> @@ -7,7 +7,7 @@ MIGCOM = $(MIG) -cc cat - /dev/null
>
> # Reply servers need special massaging of the code mig generates, to make
> # them work correctly for error returns in some cases.
> -%_reply_S.h %_reply_S.c: %_reply.defs
> +%_reply_S.h %_reply_S.c: %_reply.defs $(srcdir)/reply_mig_hack.awk
> $(CPP) $(CPPFLAGS) -DSERVERPREFIX=S_ -x c $< \
> | $(MIGCOM) -sheader $*_reply_S.h -server $*_reply_S.raw -user /dev/null -header /dev/null \
> && $(AWK) -f $(srcdir)/reply_mig_hack.awk < $*_reply_S.raw > $*_reply_S.c
>
Thanks, this is OK, although even if it's obvious to you, I'd appreciate at least
a small commit message that explains why this is needed (i.e. make sure those out
files are re-generated whenever the script that generates them changes).
Simon
next prev parent reply other threads:[~2020-05-30 14:42 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-29 22:00 [PATCHv2 1/7] hurd: fix gnu_debug_flag type Samuel Thibault
2020-05-29 22:01 ` [PATCHv2 2/7] hurd: add missing awk script dependency Samuel Thibault
2020-05-30 14:42 ` Simon Marchi [this message]
2020-05-29 22:01 ` [PATCHv2 3/7] hurd: make function cast stronger Samuel Thibault
2020-05-30 14:47 ` Simon Marchi
2020-05-30 15:32 ` Samuel Thibault
2020-05-30 16:02 ` Simon Marchi
2020-05-29 22:02 ` [PATCHv2 4/7] hurd: add missing include Samuel Thibault
2020-05-30 14:48 ` Simon Marchi
2020-05-29 22:03 ` [PATCHv2 5/7] hurd: remove unused variables Samuel Thibault
2020-05-30 14:49 ` Simon Marchi
2020-05-29 22:03 ` [PATCHv2 6/7] hurd: add gnu_target pointer to fix thread API calls Samuel Thibault
2020-05-30 14:57 ` Simon Marchi
2020-05-30 15:53 ` Samuel Thibault
2020-05-30 16:08 ` Simon Marchi
2020-05-30 17:22 ` Samuel Thibault
2020-05-29 22:04 ` [PATCHv2 7/7] hurd: fix pushing target on inferior creation Samuel Thibault
2020-05-30 15:01 ` Simon Marchi
2020-05-30 14:39 ` [PATCHv2 1/7] hurd: fix gnu_debug_flag type Simon Marchi
2020-05-30 16:00 ` Samuel Thibault
2020-05-30 16:12 ` Simon Marchi
2020-05-30 16:53 ` Samuel Thibault
2020-05-30 17:38 ` Simon Marchi
2020-05-30 19:07 ` Samuel Thibault
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48a2aaf3-8272-0ee5-758d-5ed5c78dfee9@simark.ca \
--to=simark@simark.ca \
--cc=bug-hurd@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=thomas@codesourcery.com \
--cc=thomas@schwinge.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox