From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 755A73858D35 for ; Sat, 30 May 2020 14:42:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 755A73858D35 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca Received: from [10.0.0.11] (173-246-6-90.qc.cable.ebox.net [173.246.6.90]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 9D2D91E791; Sat, 30 May 2020 10:42:55 -0400 (EDT) Subject: Re: [PATCHv2 2/7] hurd: add missing awk script dependency To: gdb-patches@sourceware.org, Thomas Schwinge , thomas@schwinge.name, bug-hurd@gnu.org References: <20200529220049.gm7vt7gvtw7if6lg@function> <20200529220123.nrbzpl7umpribknw@function> From: Simon Marchi Message-ID: <48a2aaf3-8272-0ee5-758d-5ed5c78dfee9@simark.ca> Date: Sat, 30 May 2020 10:42:54 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <20200529220123.nrbzpl7umpribknw@function> Content-Type: text/plain; charset=utf-8 Content-Language: fr Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-9.8 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 30 May 2020 14:42:57 -0000 On 2020-05-29 6:01 p.m., Samuel Thibault wrote: > gdb/ChangeLog: > > 2020-05-29 Samuel Thibault > > * config/i386/i386gnu.mn (%_reply_S.c): Add dependency on > $(srcdir)/reply_mig_hack.awk. > > diff --git a/gdb/config/i386/i386gnu.mn b/gdb/config/i386/i386gnu.mn > index 1c3453823d..5c81efd007 100644 > --- a/gdb/config/i386/i386gnu.mn > +++ b/gdb/config/i386/i386gnu.mn > @@ -7,7 +7,7 @@ MIGCOM = $(MIG) -cc cat - /dev/null > > # Reply servers need special massaging of the code mig generates, to make > # them work correctly for error returns in some cases. > -%_reply_S.h %_reply_S.c: %_reply.defs > +%_reply_S.h %_reply_S.c: %_reply.defs $(srcdir)/reply_mig_hack.awk > $(CPP) $(CPPFLAGS) -DSERVERPREFIX=S_ -x c $< \ > | $(MIGCOM) -sheader $*_reply_S.h -server $*_reply_S.raw -user /dev/null -header /dev/null \ > && $(AWK) -f $(srcdir)/reply_mig_hack.awk < $*_reply_S.raw > $*_reply_S.c > Thanks, this is OK, although even if it's obvious to you, I'd appreciate at least a small commit message that explains why this is needed (i.e. make sure those out files are re-generated whenever the script that generates them changes). Simon