Re: [PATCH 3/11] gdb/solib-rocm: pass reference to cache to rocm_code_object_stream_file

[Simon Marchi <simon.marchi@efficios.com>]

On 5/7/26 2:20 PM, Lancelot SIX wrote:
> On Tue, Dec 09, 2025 at 02:32:07PM -0500, Simon Marchi wrote:
>> ~rocm_code_object_stream_file obtains the fd cache to call "close" on
>> using its m_inf field, obtaining the per-inferior info using
>> get_solib_info.  A patch later in this series moves the fd cache from
>> the per-inferior registry to the rocm_solib_ops directly.  This implies
>> that we will need a new way to get a reference to the fd_cache owning
>> the fd, as it won't be easy to get it from the inferior anymore.
>>
>> To achieve this, update rocm_code_object_stream_file to keep a reference
>> to the fd cache directly (because the rocm_code_object_stream is not
>> meant to be copied nor moved, make the field a reference).  The inferior
>> parameter and field are not needed anymore.
>>
>> Change-Id: Ia10f8f125840274e51e188cafcb7384fdff92240
>> ---
>>  gdb/solib-rocm.c | 19 +++++++++----------
>>  1 file changed, 9 insertions(+), 10 deletions(-)
>>
>> diff --git a/gdb/solib-rocm.c b/gdb/solib-rocm.c
>> index a9573f8eefde..bde34bafd8b1 100644
>> --- a/gdb/solib-rocm.c
>> +++ b/gdb/solib-rocm.c
>> @@ -360,8 +360,8 @@ struct rocm_code_object_stream_file final : rocm_code_object_stream
>>  {
>>    DISABLE_COPY_AND_ASSIGN (rocm_code_object_stream_file);
>>  
>> -  rocm_code_object_stream_file (inferior *inf, int fd, ULONGEST offset,
>> -				ULONGEST size);
>> +  rocm_code_object_stream_file (rocm_solib_fd_cache &fd_cache, int fd,
>> +				ULONGEST offset, ULONGEST size);
> 
> Just noting that this does not apply anymore, just need to change
> "int fd" to "target_fd fd".

Thanks, I saw that while rebasing.

> 
> Other than that, this looks good to me.
> 
> Thanks.
> 
> Approved-by: Lancelot Six <lancelot.six@amd.com> (amdgpu)

Ack, thanks.

Simon