Re: [PATCH 06/11] gdb/solib-rocm: move per-inferior data to rocm_solib_ops

[Simon Marchi <simon.marchi@efficios.com>]

On 4/28/26 12:19 PM, Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi <simon.marchi@efficios.com> writes:
> 
> Simon> Move the data currently stored in an inferior registry directly into
> Simon> rocm_solib_ops.  This changes the storage of this data from "per
> Simon> inferior" to "per program-space", but it should be equivalent, since
> Simon> there is usually a 1:1 mapping between those two.  The only time there
> Simon> isn't a 1:1 mapping is during a vfork, before the exec/exit, but no ROCm
> Simon> activity happens during that slice of time.
> 
> Worth noting maybe that solib stuff is already per program space so this
> probably is more correct in some pedantic way anyway.

That's right.

> Simon> The rocm_solib_ops constructor has to take an inferior as a parameter,
> Simon> rather than a program_space, because of the fd cache.
> 
> I wonder if this could also use the program space.

rocm_solib_fd_cache::open calls target_fileio_open, which requires an
inferior.  If rocm_solib_ops took a program space instead of an
inferior, we would probably call find_inferior_for_program_space in
rocm_solib_fd_cache::open to get back to an inferior.  Might as well
keep it inferior all the way.

Simon