Re: [PATCH 09/11] gdb: add objfile -> solib backlink

[Tom Tromey <tom@tromey.com>]

>>>>> "Simon" == Simon Marchi <simon.marchi@efficios.com> writes:

Simon> However, I learned that there may be more than one solib linked to one
Simon> objfile, so this backlink is actually a vector.

How / when can this happen?  It seems surprising to me, except maybe for
separate debug info.

Simon> @@ -732,10 +733,14 @@ remove_solib (program_space *pspace,
Simon>    notify_solib_unloaded (pspace, *solib_it, still_in_use, false);
 
Simon>    /* Unless the user loaded it explicitly, free SO's objfile.  */
Simon> -  if (solib_it->objfile != nullptr
Simon> -      && !(solib_it->objfile->flags & OBJF_USERLOADED)
Simon> -      && !still_in_use)
Simon> -    solib_it->objfile->unlink ();
Simon> +  if (solib_it->objfile != nullptr)
Simon> +    {
Simon> +      /* Remove the objfile -> solib backlink.  */
Simon> +      solib_it->objfile->remove_solib (*solib_it);
Simon> +
Simon> +      if (!(solib_it->objfile->flags & OBJF_USERLOADED) && !still_in_use)
Simon> +	solib_it->objfile->unlink ();
Simon> +    }
 
Doesn't this mean that if one solib is removed, then other solibs with
the same objfile will have a dangling objfile pointer?

Tom