From: Simon Marchi <simon.marchi@efficios.com>
To: Lancelot SIX <Lancelot.Six@amd.com>, Simon Marchi <simark@simark.ca>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 1/11] gdb/solib-rocm: assert that host ops isn't rocm_solib_ops
Date: Mon, 8 Jun 2026 14:36:15 -0400 [thread overview]
Message-ID: <540f12ef-d4b7-4288-ad6b-03cbad2878d3@efficios.com> (raw)
In-Reply-To: <e28f14bf-eff5-481a-8bb1-c81b785c0b66@amd.com>
> My main concern would be that most people contributing to GDB do not
> build the amdgpu target (requires the rocm-dbgapi library to be
> available), so it would be easy for many to build with
> --enable-targets-all and not enable this code path.
Even if some people built against dbgapi (which is not that difficult),
even less people would actually run the rocm tests.
> That being said, we (at AMD) would pull such change from master and
> hit a CI failure quite promptly, so I do not expect this would be
> un-noticed for very long.
Exactly, if the core happened to change, I think we would like to know
(via an assert breaking) so we can check if something needs to change on
our side.
>
>> So I'm still team 1) for the moment. I guess in general I'm team
>> "use asserts generously".
>>
>
> I am happy to follow you there and keep this approach.
Ok, so is this Approved-By?
Thanks,
Simon
next prev parent reply other threads:[~2026-06-08 18:36 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-09 19:32 [PATCH 00/11] Multiple solib_ops in a program_space Simon Marchi
2025-12-09 19:32 ` [PATCH 01/11] gdb/solib-rocm: assert that host ops isn't rocm_solib_ops Simon Marchi
2026-05-07 17:56 ` [PATCH 1/11] " Lancelot SIX
2026-05-08 1:37 ` Simon Marchi
2026-05-08 10:36 ` Lancelot SIX
2026-06-08 18:36 ` Simon Marchi [this message]
2025-12-09 19:32 ` [PATCH 02/11] gdb/solib: use early return in solib_read_symbols Simon Marchi
2026-04-28 16:16 ` Tom Tromey
2026-05-08 1:44 ` Simon Marchi
2025-12-09 19:32 ` [PATCH 03/11] gdb/solib-rocm: pass reference to cache to rocm_code_object_stream_file Simon Marchi
2026-05-07 18:20 ` [PATCH 3/11] " Lancelot SIX
2026-05-08 1:48 ` Simon Marchi
2025-12-09 19:32 ` [PATCH 04/11] gdb/solib-rocm: add cached_fd to manage cached fd lifetime Simon Marchi
2026-05-07 20:17 ` [PATCH 4/11] " Lancelot SIX
2026-05-08 1:52 ` Simon Marchi
2025-12-09 19:32 ` [PATCH 05/11] gdb: de-constify some methods of solib_ops Simon Marchi
2025-12-09 19:32 ` [PATCH 06/11] gdb/solib-rocm: move per-inferior data to rocm_solib_ops Simon Marchi
2026-04-28 16:19 ` Tom Tromey
2026-05-08 2:02 ` Simon Marchi
2025-12-09 19:32 ` [PATCH 07/11] gdb/solib-rocm: save inferior in rocm_solib_ops Simon Marchi
[not found] ` <87a4unm59w.fsf@tromey.com>
2026-05-08 2:10 ` Simon Marchi
2025-12-09 19:32 ` [PATCH 08/11] gdb/solib: add remove_solib function Simon Marchi
2026-04-28 16:23 ` Tom Tromey
2025-12-09 19:32 ` [PATCH 09/11] gdb: add objfile -> solib backlink Simon Marchi
2026-04-28 16:28 ` Tom Tromey
2026-05-08 2:25 ` Simon Marchi
2025-12-09 19:32 ` [PATCH 10/11] gdb: change default objfile iteration order to start with current objfile Simon Marchi
2026-04-28 16:42 ` Tom Tromey
2026-05-08 2:40 ` Simon Marchi
2025-12-09 19:32 ` [PATCH 11/11] gdb: multiple solib_ops per program space Simon Marchi
2026-04-28 17:27 ` Tom Tromey
2026-05-08 2:52 ` Simon Marchi
2026-04-28 16:00 ` [PATCH 00/11] Multiple solib_ops in a program_space Simon Marchi
2026-04-28 17:28 ` Tom Tromey
2026-05-08 2:40 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=540f12ef-d4b7-4288-ad6b-03cbad2878d3@efficios.com \
--to=simon.marchi@efficios.com \
--cc=Lancelot.Six@amd.com \
--cc=gdb-patches@sourceware.org \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox