From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id oTzjDcQLJ2qqfDwAWB0awg (envelope-from ) for ; Mon, 08 Jun 2026 14:36:52 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=efficios.com header.i=@efficios.com header.a=rsa-sha256 header.s=selector1 header.b=sE7heUGZ; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 3495D1E0A3; Mon, 08 Jun 2026 14:36:52 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=unavailable autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id BAECE1E062 for ; Mon, 08 Jun 2026 14:36:51 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 545C744EBD4B for ; Mon, 8 Jun 2026 18:36:51 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 545C744EBD4B Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=efficios.com header.i=@efficios.com header.a=rsa-sha256 header.s=selector1 header.b=sE7heUGZ Received: from YT6PR01CU002.outbound.protection.outlook.com (mail-canadacentralazlp170120003.outbound.protection.outlook.com [IPv6:2a01:111:f403:c103::3]) by sourceware.org (Postfix) with ESMTPS id 37B5151A4317 for ; Mon, 8 Jun 2026 18:36:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 37B5151A4317 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=efficios.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=efficios.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 37B5151A4317 Authentication-Results: sourceware.org; arc=pass smtp.remote-ip=2a01:111:f403:c103::3 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1780943784; cv=pass; b=b+C/O8cXNQoOvxX6ia1vuNmoTTD0WQ0QOSjs9XO5yNyecif5J5GlmJ1r8/tSGg7+G6qP91H1OTh76ZYL0ZslUaM6cpBfSoy3wox8G2gPW/iTieG5sxxbOz+xfBf70m+ZeiFPBqYzDNLj7yEq2M9PM690pfBGKRYX0PXUTLBYugs= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1780943784; c=relaxed/simple; bh=DGu2D98LlHZtoTFCS5bPNFmShHXEqHIzkDoraDm0VQA=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=LGoRfAP+wu5C+ldbTrMud4Qdahn39UhAOtPgvUQFHOGOFIqJItSz8UJQ1Fp1itb+KTr59ESYacYt/Fz/oCrRz1wVHQDMrxw8KupVvsOPXq6IBeSn4B7tbpe0Y7wnjS6IfTEVHR9qC1sqlUVdyRVEDehb7Tz5yOV0ztZ3XOaST6A= ARC-Authentication-Results: i=2; sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=efficios.com header.i=@efficios.com header.a=rsa-sha256 header.s=selector1 header.b=sE7heUGZ DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 37B5151A4317 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Ayn2s1b5d7SJdVrH6aZ9Vl7GCfvGP7ESn6MrbAAJIbe37DhMKXXzQJys7tCV29a+6qEfjjCh5Ufv5NzwAXWdPXfxTLo+DzfYFN5TPN/nF/vMPacUlm6jh6NOLQxELg1dZaueXxxKL2G2Gpj5YfYKng4gpfwQiSLdiuRXb2U21txHEVjxZTFMyeTvaMGworyNWLUWAwPyz9FvdKGHgZp1TOaKVBwDgGqK3mRy613FyOXrF6xhvJMmdz/ZmPPQsyUzk8gLeWEIjdSbs1nJSZhIE5xeiGHGmWRSPKDGQ65xJYwnGHZyzlWp7+ekiWAHPolhXNxRZ/VocXXwi2lTHvZJAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pf15o9vXFDiD4E4mgXgUeeRi+i9UYvrV2dIlVkFx8js=; b=hofCakBPB0u+n6rzA9/TOw/n1y5hMiAaTd/1IIXnHjKx6mz7hQYd9VlEmUbpR/QZr/vncb87oR+zm6kEgFr66ldIwazZIlVTeFm3Ox/MgcQdSnSRJEUVPJquAtpIYhVsiMwJ3t6DTk5921IuZJ3V4/VP4gQJ4M0ty7LmYyzfX2rwYgeYoWtCYNRfuQbsWoKBG9/GfOHimrJ3L9Cv2V/RXq2O3rkTQt1GAXo5szvq1iRR0F235vlMkAS1gW+dVpEctJ1/xzO9WkKtRH6+f6nwk6UYwMbX0FgXzucjzvJ2Lj1ma9k1fKXn439tNMYY37B/JM/Ga8l3jzvk1NQxCsyUFA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=efficios.com; dmarc=pass action=none header.from=efficios.com; dkim=pass header.d=efficios.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficios.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pf15o9vXFDiD4E4mgXgUeeRi+i9UYvrV2dIlVkFx8js=; b=sE7heUGZulYLuLHmD0LDPlX/Lb2eXRiDEbqM4UhWNrpT5LA2nKQYCG/jBeWkkN15GgTUdC1h429uVWRpj4sugaWwmrZoOApaCQsLsI3b1VKfZMAYNnH4UabNfanzMyM4odaBkt7nUDEXP4AUHmdm00peaZ02j0P/JMeBBP/o7SVj3oMXueNztV1zLTIsWegXOtiotjBxR3gjjHz9GZd4oaLiIuo6q2471ez+4OQL6PlhCgJ6J8UqyYkzb28GYkdo/5mNEe5bys5gccAmHh3mcOT8BOt3Gv3qPazfMW6U4Ww2LKZwicdbHqyujMNoZKFwBHPVB/1++3cFuaQNcIaSuw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=efficios.com; Received: from YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:2c::6) by YT5PR01MB10882.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:136::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.113.9; Mon, 8 Jun 2026 18:36:17 +0000 Received: from YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM ([fe80::bbfa:179f:fdc8:b15d]) by YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM ([fe80::bbfa:179f:fdc8:b15d%3]) with mapi id 15.21.0113.006; Mon, 8 Jun 2026 18:36:16 +0000 Message-ID: <540f12ef-d4b7-4288-ad6b-03cbad2878d3@efficios.com> Date: Mon, 8 Jun 2026 14:36:15 -0400 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/11] gdb/solib-rocm: assert that host ops isn't rocm_solib_ops To: Lancelot SIX , Simon Marchi Cc: gdb-patches@sourceware.org References: <20251209193610.296085-2-simon.marchi@efficios.com> <223ae525-3642-46e3-8490-f8d17de90968@simark.ca> Content-Language: fr From: Simon Marchi In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: YT4PR01CA0039.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:fe::28) To YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:2c::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: YQXPR01MB5418:EE_|YT5PR01MB10882:EE_ X-MS-Office365-Filtering-Correlation-Id: 4ffc6ce8-c53f-4b2d-57bb-08dec58cd332 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|366016|10070799003|1800799024|376014|4143699003|56012099006|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: zrvIKQ/l8TIGzBX5m1kiIrEEGSIkTUfBniMH9MuYMgf1m7y4RAVOxlyc5KA6YlSoPxI94ua9iKHcyAXLEFlIY398pqSf7/VYkdilI3wAS81jy8SYiFWaMwGnuQpncVxUMmrnhDUxIMNon64WVrdZGBXtTZTnA501Q47TjI6vMOBoN/pYlwzbARWbKzi1YGaecVmS5UQpHE5QzqQ10N20kHfEmGRGivfcwXWqVoEOwCd7fzx7FyiFQebP75Ab7UD3ZVqb2inGkl1WCS3hVcAYrslCF0Jwp5BevV4/1vc7/xHKDi9HqXmLRadZp6sfJSg8uJx/9gPKEXRMmrbpoWVIIpL14BExwL8JJhgQRGaNfdhVTEZcA9ce8OSTXzb7WcLMW0jh796ORxjjxFD+Ee4cQBq7OiFU4vr8fb6jZCqVh2EF0ZTTQy6sbdDbtCd4xSURVZCQm0StNc4hyPZ4zeZFRDZEwe4dYUvMB0Ntk/QaCa1syhoQ+kUcg3YHGBKMU0SNb+yClMkPc58FRvEEuOkQfQ+nSfTL/ZZH8wS8LY8UR2izb8ZwoGCn59NR4J8H2AZU+J/MY9LrckjJQwOho1rCEbdVS1oZxENeOELBYFB3kdPrqwQk8WTx8azHQCxKU5sYviB9zq/TQyjh+aV+TkSijHAl6zZlGidbAPwU+KcfUix4Qir5LFQmJo/45nAW6DF4 X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230040)(366016)(10070799003)(1800799024)(376014)(4143699003)(56012099006)(18002099003)(22082099003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SjhWRGg0TUZtVDVSWVNxQ2dKVWM3ZXZuZ21QV0xGZlkxQ1pUc2hobCtwKzJM?= =?utf-8?B?a2s1Y3p1L292SXlpVGZRVWtxM2xjY1U1ekVtZ1lsK2dhNXZCeHZqUWRpZDNF?= =?utf-8?B?Q2JseFYzcjhLbU5hVnY3OXlWdmo0S3g0a2xDY0NuYjJ2VDZwVEJhRy9jMWlz?= =?utf-8?B?bWpJcGQ5dmhZMjZQbzlRWUM2REUwQlo4Z0dTVUZyS0xiUXdQdWNLejNQd1Vq?= =?utf-8?B?bWJ5NlBBVVBXb01jZ05ZQ3JZdnFrdWlMVGl0VmF4RHFZeDAyVkNYbXpKQVM0?= =?utf-8?B?QTRTRTEvekh1MlNITVlDRmtpNStScGxqMU9YSVVBMHFQNFMybXJycS8xeWMr?= =?utf-8?B?aWdRdE5RcDFUanc3Q3dZT0JlSEh5SHg2K1pVK2dyTHFWWExhb1lRNWx0OHR2?= =?utf-8?B?Vm5Lei9IbmFHMis0TjdwZzBPajRDV01uQVV6dDFqeUdaWlIxN09yeEh2MW9P?= =?utf-8?B?MjRIRkJxVUNvZ2JNZ1NKM0tIMGp1bThBeTVXbzFyaUVURDRvejdOTnRuMndF?= =?utf-8?B?NVJBa3FNOXM0WmNjZHYxZmpqVjRnVHJtamZ5T2t4K2VwL20rV0xRVEQxMGxm?= =?utf-8?B?U2dIeGdCSkc1MVlzWXI5K0VMRlJBOEFYV1Z5Z2pOaUE5TXAzUE5LcWpIeVR2?= =?utf-8?B?K1NsNFkreUpXZVVoWWFjVXVOMk1sTEdKM3dZYVMyTnNKZVB2cEs2Tzc2MGUw?= =?utf-8?B?bUlTdll2ZHJrSE14YnMwMkRoQUsvNE4ydWNhR2tYNldFZjJIN3RTV2p3NWFz?= =?utf-8?B?MDdjUGV4SGpEanZldmNVcDJjWUFGMUVUVlIzdmtYMGJmWGFITXRIRGdQbEEr?= =?utf-8?B?VGxnKzVySmdOWmk1TWVZVDZKTVBNTm1sM2FOMndsZlpFMnpzS0EzYzJPVlVq?= =?utf-8?B?bDlpRnRnampmbExCUis1SmpYUXRJOWFUMlo2bFdKamVEN3JVUm5uNHlMVGJT?= =?utf-8?B?ZG5pdDFzRCtkZjBFSEphVTYvSHRveXQvcERwRTNCUW5KVEdkOU5iZDZFcjJa?= =?utf-8?B?L3VabW83QTFLOE5ZY2JnZ3NiTzUxalFmeFVlZDZ0SXVWVGpza3YrdFFZZE9X?= =?utf-8?B?OXBhMWUxK3NIbkNPQ2hweUdvMlpvVUV3TEdlQmNMcjlhNTZyV2pMcC93blov?= =?utf-8?B?cHVjYm5uRGhrbEU0V0w0d3hEUFZEOGx0bjc2ZEdLQVdrVC8rTGgxbFZUTTBy?= =?utf-8?B?ak5BSHFUYzIydElLNlF3SHVLZ0ZUVGlrbXN5aXc1QW15clBBRmx4WEx5STkx?= =?utf-8?B?bHUvaDM4WVRUUFQ0elpxOExCQ2tsaWlMWXdVeHZzVUVJUXZYUFlKWXBLVEJy?= =?utf-8?B?SDBmbEk1RXVEZFhkcmc4ZmVoN3JXcGE2bkFPWlJDcnh4WEVzMVdHMHNGcHZz?= =?utf-8?B?RWNBNGRHSGxYanlPL0NZNTdBQm9LVXhuOWFwdWNYTnlmRmoyMUZzd1hwQU94?= =?utf-8?B?b0ZBYlorcDZTNGcrQWJMbmpwa2pvWVpETkpTTjF0bDAxS2RkWkc0WFFGZG9y?= =?utf-8?B?anhHYVNPWnpQNW1tWDhFTFZTU0t3dytlZUhVWGNCbDd1bTRVWUF1OTVhZjRk?= =?utf-8?B?WmNFQWVxeTAyYjJRWWRSWmxTdXJEalA1cDI4eUJqblRhZk5VSzVGa1k0UzUx?= =?utf-8?B?WGZ0Qk5vYlhQMGpZdXlOUlV5eEZkSzkyZEhVWTF5REFVTVlaTjl2WjZ2ak9Z?= =?utf-8?B?QlF5cW5XU01XYlF5ajEvb21kQVU3MEJtU0Rxa2dGaWtBK3QxYytvTVlQY2E2?= =?utf-8?B?L1huRWwxV0ZOWlZTeWJLYVNCdS9mSE92a0VOZERvaW81R0x1YlNHUVhwNkQx?= =?utf-8?B?N2pnRXhUWUFDZXk0L3dyejNvYTE5K2ZUYWY2UmwvZVZ5N3l2Vzc3THpoVmlS?= =?utf-8?B?cXVSVFhmUG44S3U1SEQrb1hPKzRxSElxRSticUNEaktSUHQvSGRIM0hZbG5X?= =?utf-8?B?ak41cVVmZGZNM2FqdUNPWmZGenIwcDcya0daSnpsVmp2TndqMzZFb1VobzBn?= =?utf-8?B?YlowSlB4bGlqWTVNUysxaFhNNXd0ejRiWUhpcTN5R2xlbmhTQ0l2YnFOcGFB?= =?utf-8?B?UHRqU1Faa0lQeTNCSFZoM05tUE9VdE5UT0R2bzcxRWpTdE5LcklsWE16eTdE?= =?utf-8?B?SnlnOFZqUjZ5Z2FHT1hSSkNQeHFHV1dZTXZHME90ZFVJM3J1bnVERk5wZ2k2?= =?utf-8?B?Q29scWNWR05CVVpvbklrc0FoNk52TnNTU0N3ZlRKV1loTGkrUi85QXJRMjRi?= =?utf-8?B?bHd4OEdEUGc3cWpGYTFkaXZaSWZpYlFiTDZUYkg4bEtFRk5hYnAwNE5sYjcx?= =?utf-8?B?OWwxS3RMTFVReVpoL2F2b2MydU9rVm44eDJnWFV0bmxxKzJKZnNZQVhhNC9X?= =?utf-8?Q?PxOtpVhseBSiMLcK0LiYFw0dh/OP9H5+pKfG2AhFy53EK?= X-MS-Exchange-AntiSpam-MessageData-1: yGXFCsTj/YDaAg== X-OriginatorOrg: efficios.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4ffc6ce8-c53f-4b2d-57bb-08dec58cd332 X-MS-Exchange-CrossTenant-AuthSource: YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jun 2026 18:36:16.5184 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4f278736-4ab6-415c-957e-1f55336bd31e X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ozn/04RGu01Nmx+MmUmrrX079shjNkE1s0/6ABl3sBJi1rBivyyLjtjETiUgXy6G4gLpIuC9zBpS555XezCiEQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: YT5PR01MB10882 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org > My main concern would be that most people contributing to GDB do not > build the amdgpu target (requires the rocm-dbgapi library to be > available), so it would be easy for many to build with > --enable-targets-all and not enable this code path. Even if some people built against dbgapi (which is not that difficult), even less people would actually run the rocm tests. > That being said, we (at AMD) would pull such change from master and > hit a CI failure quite promptly, so I do not expect this would be > un-noticed for very long. Exactly, if the core happened to change, I think we would like to know (via an assert breaking) so we can check if something needs to change on our side. > >> So I'm still team 1) for the moment. I guess in general I'm team >> "use asserts generously". >> > > I am happy to follow you there and keep this approach. Ok, so is this Approved-By? Thanks, Simon