From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 4RDNMnFE/WnIeSAAWB0awg (envelope-from ) for ; Thu, 07 May 2026 22:03:29 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=efficios.com header.i=@efficios.com header.a=rsa-sha256 header.s=selector1 header.b=qg5nQmU7; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id CAFF21E0BA; Thu, 07 May 2026 22:03:29 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 536911E093 for ; Thu, 07 May 2026 22:03:29 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 7317A4BA2E29 for ; Fri, 8 May 2026 02:03:28 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7317A4BA2E29 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=efficios.com header.i=@efficios.com header.a=rsa-sha256 header.s=selector1 header.b=qg5nQmU7 Received: from YT3PR01CU008.outbound.protection.outlook.com (mail-canadacentralazlp170100001.outbound.protection.outlook.com [IPv6:2a01:111:f403:c103::1]) by sourceware.org (Postfix) with ESMTPS id 26CB64BA2E0A for ; Fri, 8 May 2026 02:03:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 26CB64BA2E0A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=efficios.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=efficios.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 26CB64BA2E0A Authentication-Results: sourceware.org; arc=pass smtp.remote-ip=2a01:111:f403:c103::1 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1778205781; cv=pass; b=kq51lAO+hgcr4R4FSyxG7yDFhM6ma/y/Vlv2etJEGv+bTaV0setkCuKoaPadVV6/dSJJkL/pLv1wLljrKVs5tx99aT8jr0OSf38BA2oI2JT/1kY15E+UaDFzpyeJVxqLU2jSqrM4GmTCNCuaQoLumdYW8ZLhVuTZhq5z0PNFDtI= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1778205781; c=relaxed/simple; bh=GvBtxV5vxsx5U/FhtIp+6MC0t5AhWVUUoiVFLb+UFfI=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=GYZ/58n5hS9TGmK/WCyiLGrC9XH6Yr+K2zIaBLQgHuSBx6C5XshhFDPzc8x30uqUTkbeAx9Iv2xkVGn1FtSwC3ZPRlUEi9mymWcKU3pfFwepR4lao5IToAq8PlB10Dpgwx99l9sBPBGxx97C8NuAhfk10Y65lcoU0zrC2qF/XvA= ARC-Authentication-Results: i=2; sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=efficios.com header.i=@efficios.com header.a=rsa-sha256 header.s=selector1 header.b=qg5nQmU7 DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 26CB64BA2E0A ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=FpH/Kz/pHlm0z4KigRvwcUVa/p2iVksJTys1frujbqDicU0OkJDMDq9aKtop/Tf9h2/ldpnOdO+uM5tkS0mRKxdedyXK00l5RWlFDPXHYmKTE4eFNnvoxNoHsy/X9JVDBZQXVcQ7iax9sqwqw1kfKozeWHTIFroB2i8PUkvVMz74eu8RS8IwUvB1WFfoe3Bb1+X0Fzh9SLpEj1h/7PXkiLcDcbCnXL4O8QYnWe4cShu2v9KRgg8dUUeYA94mcLB9vzxjRV/Lktw28TRjaP3AudF4sO8kHOozH2H9NLxP3ME7n+HXI+yzUthazDuJJW1DvvXKbITBjf/1JPIciaLIUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=66qAEZPJ99h/aLeQ/7wHjKCsZ6w1K/rLKqdFCS2+7R4=; b=azu4tsWUmDVMvTtXmJCBNNUCZ71ELq3KkK6+rOGP3LSHkSB4r6K9Ayh7lPk/gQwFBKFD5aU6EMQomGD6ghSGgRlBl6PIlkrSN0k1g7i0T8TqwMUWcEh0uowozRkrdVOJFAeWo2+vQxVc+bGdD9okA7ggeNbYb3naUMBWcvX0hMI4rQpWr0LKGMBuousLH8ZPW2Y21Ygi7Bqt4Ps30MYA3lPkp9lBJ1FpGOhC513ekbAf1KZJlbTz60MTJVeU3tHGhJMhUUGsjbMAAD79JTNORB8Nfohc2sSGjimSIRkLXgre5UJSFno4QO4SkBLb/tujbvtgN8QCG22M9RBBb0fqBA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=efficios.com; dmarc=pass action=none header.from=efficios.com; dkim=pass header.d=efficios.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficios.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=66qAEZPJ99h/aLeQ/7wHjKCsZ6w1K/rLKqdFCS2+7R4=; b=qg5nQmU7gGc6dPeY2NwFwm4ud1UVklGqmSrHjfMtgFSrdWPSU/Yyl3DlU7frZHrBSAdv96KD2Tf2eGTuAIPn/gu4n1PMgHyD2iZahneTdnftonu+e4O1MtkPov347Ak77Odr+IG/XGF6h2y88qDyELEPTZVHp1nICYf0Qc6FZOZUNMLTl5sAQDtc27lMcHETdeZ+XyCd93LdkK+O76eYLb2kclCFF1Va91pngonn661FatCC1QH06VLA7CkU9DP6L/0O0tLIKfHJt0YG8Eoze1A1uH5zfDXTvuRVy/1u2pNyFTZaRQmc416CoDpuQOikXSRrHGc3KE53YzZCRTvIAg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=efficios.com; Received: from YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:2c::6) by YQBPR0101MB9151.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:5e::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9891.16; Fri, 8 May 2026 02:02:55 +0000 Received: from YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM ([fe80::bbfa:179f:fdc8:b15d]) by YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM ([fe80::bbfa:179f:fdc8:b15d%3]) with mapi id 15.20.9891.017; Fri, 8 May 2026 02:02:55 +0000 Message-ID: <5902413d-482d-45ad-b603-4b78810ea75a@efficios.com> Date: Thu, 7 May 2026 22:02:54 -0400 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 06/11] gdb/solib-rocm: move per-inferior data to rocm_solib_ops To: Tom Tromey Cc: gdb-patches@sourceware.org, Simon Marchi References: <20251209193610.296085-1-simon.marchi@efficios.com> <20251209193610.296085-7-simon.marchi@efficios.com> <87wlxrkqgb.fsf@tromey.com> Content-Language: fr From: Simon Marchi In-Reply-To: <87wlxrkqgb.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: YQBPR01CA0149.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:7e::13) To YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:2c::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: YQXPR01MB5418:EE_|YQBPR0101MB9151:EE_ X-MS-Office365-Filtering-Correlation-Id: 047f83e5-9b4e-4a97-e83a-08deaca5eb35 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|1800799024|366016|56012099003|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: /bqxlq167sTrd2tgZabprGiXeJInVfP+NDv5y3gsccoSnKgXYrkvt2kDPOg9YorgFlC93jdJXJ3Gs5kWx2HJtBDfvHnIWrdMqwOSkJ6cK0YbmNKxJdBDEWSHIS2JYWwXU/MquoA3fVJ8wB3UvK6MXCIXIYJzKsvcwGkRq7GMzZXjssH9xPSlmZuZW1vQO6n7BIdCJKbAFvFEagOarPR9V4FlPC3tfONYSAC/yYDfFtY3zkquRtgqn8ljXpr7/xluyspaxXDobQyFpF8KCl+HMzJIik6d934j3/0LHVOeG/fSUXu2HST/FuF6JsH19dtK7sWu8bKlREqA+0erJBaEpJfiGWg3m1u7F16lqY+MgFOB9Xo/JzxlM26npwSOjKVGu8FPEc5197CXfXYNt3CoLZObDZT4cevKGKQbvrVy7hcNG9dI+afUh0FoWJmAJ6zayYoySaGytkQVh6BLqU6Ngvn6hzq0FYDa4LYaHAyhjlyBQ9ULmCQxv24lK3+y4mZdqEh/dEQzjim49jINxaTFIExcf2tu4vPwtYC8uS7J1agIdaghgF9SNjmE59cWt96EgVenvjCBygt4Q9b+LwG0g0sGFNOkFFNRmaYOL2z5ZbcSgoHj9slfizt3JawegzGCYtE2QJe+iyyv7RnRkPbZcRlvhvrh/u2TU592mvXvIraL9MhNcLxYpM7t/x0T69Ve X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230040)(376014)(1800799024)(366016)(56012099003)(22082099003)(18002099003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SmFWYUFKbkJzendLekRYOUpJbFVSbmlBaUFYR3pHcGVaNkcrYkhYcFhVenpQ?= =?utf-8?B?blIrMC9VVUFUOGkrZ1pnWi9DQkVqaU9OaE1PK0wzS0pxYmVMdlZEUFI4NUhv?= =?utf-8?B?SkhEVVRjTExCNkhaZ3hSK2hxUWJNQ2RtUWZETHpYdkIrWldZMUhiQ2djRnZw?= =?utf-8?B?VS9VYUc5OWpGOVppVWhaTzFXbFhNbjlBM1ZRbkNOaDhsRFFNald6RXhza3Ja?= =?utf-8?B?MzNRVXNybzRqbUpMMEE0Zi9LdnladGs5ODl6VVJxaDVQWXVZeDhiWkVQVi9a?= =?utf-8?B?Z0VOL2ZHOVluUmYrN0FlbFhJRUE0SmJ1WU5lNUJYVDVYZVZKUDNOdFpoUnhw?= =?utf-8?B?ZmF6NXNQVi9uUDNGYlA4a2o1MElPd3J0M1pxZ3ZlMUVCRDVSTHBIem45UGpl?= =?utf-8?B?SVNoWGEzdlEwbUlRN1VKdlRCZzJVM3FycUlQdlExdEpZQ3FMcW01SlZnS0xF?= =?utf-8?B?bUtQRVlaWE1pcEdUb3dMeDd5QUN2NzIwaDFPQ2xpK2JtWGdWQkdLRlY3ZEw1?= =?utf-8?B?cExtOWZYdm1OSGc1L2tNOEdmL3ZWSkRIRUlGbkN3a2d5OHAzaUpIWjhvR3B1?= =?utf-8?B?MGJteEMwbmlJUTVPZjlyZ0toTENrNk9nQ2RIOTUxMUo5Ym8vSWVxdWVLWDAx?= =?utf-8?B?bUtmcVFnU091TDZRTXd2WXFVZjFYaUt2cTBWVjZQQ0ZmR3I1T2lkWFNTYmNK?= =?utf-8?B?cVo3eGZBOTMxdDE2aGd4Y2g5ZjVOYTFzMnJUbmtXSVBGZjhjKzNyVW91Nzhz?= =?utf-8?B?djNwTDZOdWg0TE9zeHd4ekk2ZDZpaUlEUTYwRnU5YWRUa2JSSEdNaDBoWlpv?= =?utf-8?B?QjMzMERUaVJRTnZRREY4Z05rbE9mVlBSOXdXRW5WVDB4WXE1WlN2dzF2bDVY?= =?utf-8?B?RElSdFRWSEZ4cnRvY1VWU1F4aXJIeHVrczdUNGtVVEtBYVBsTVRxZGJNLzI2?= =?utf-8?B?d0kzZi81K2hEaDRHekdnZkI5WWRBeWcyTm1ieGtrRE4wQzUvRDEzN2NJdzlI?= =?utf-8?B?UjlQbVZ2U2FsYzZJS2RRUnNvNUNFMzVXTlpDS0lySEVobHRudGU4MHFxaTFC?= =?utf-8?B?dzlkSUxyR2w5UElJdWlyVGlBYm9QdkhVd0doWlFSRk5abHFsQUhQN3QrQ0JL?= =?utf-8?B?UjduMXAvTXFvM2VYMExUemtFZG1rNlFRN2JwR05SemRDQXMxTHArZy8rYXEy?= =?utf-8?B?OFBjeDdpTFlPdGYrR3FGcnRnWU1GS1JZTkdmcE90UHdwK0Y0bTlKVzBoaGdT?= =?utf-8?B?NWpQMzZxbTFlVGJlT1BtYmhrd2tSSmUyYzZzVGY5ZHlFckt0dGozM0Y2d0N1?= =?utf-8?B?TlNpK2x6TUNua1pRc2IzbW1rTVpleHJXamN4aENHc2pzcDg2eVVsVi9QVHV0?= =?utf-8?B?cXlmTUFNV0cra2w5UE9rNGV0amFKZ1pKM0Ftc1JkTjUwTkllSlNTN0R2alJO?= =?utf-8?B?ZTZVWkNCOXZKc0EyVkhLQkczclA5bHJjS2NJaUNYK0pyOHMyS2NTSWxkMTRL?= =?utf-8?B?SWphVkZ6aFVMY1NibFFRNFFFcTFPTm5OL2gvdDJneTdGVmpTdFhEcGVWSFhk?= =?utf-8?B?SVRNemxiRTRVOXRuQ1I5ckVaaEp5TTBsKzUvMWRDSW1iNFNIVXdOTFc0clFr?= =?utf-8?B?QUxXckFUa1BEak40cUgwRnd3d01lWTJrMnBGSGQzQ3pJSXYwOERJSXRoMnZp?= =?utf-8?B?NXM5alRtQnFvOXkwZlFqaEFsSVUxU2hlNVlMNFo1Z1lnL1N2U3V0Ry82ZmIx?= =?utf-8?B?Z2R0aHkvaTNJVHNmUitTUzJ5SWJtTS81RlZDL2piaVdpZ3JZM1dJR0lDNFZ2?= =?utf-8?B?WDQ3bjdKc25VTkRqeGM5cEM2elNxN1BOT3FIQkZZeE5QWXhQM09aQThGZFpm?= =?utf-8?B?MTJjcUdwdWcvM25hdUJKNUkwblh6SHJtTUZIOTR5ekF2V2VQN1lNSnVRcjli?= =?utf-8?B?RHcrRWpabGVyOWV6NTF1RnFDOHBDMWVIRWxjdUk0WUFVZGt6QUJIYmhjSEkw?= =?utf-8?B?aGVLRUQwdkZGNnlvR2R4TVZSWUIwTE5OdmZ5NmR3bjI2K0VYNmNrdlg5YklJ?= =?utf-8?B?d3F3RklYMFoxUzJ5bGlCeHVuSkI0MkcxdE1reW9LYVZEQTJkQSt0MDcrbTEz?= =?utf-8?B?YldqeGZIUWN4UHg2elIyWWo3UFBtcVZ3aUorVW5zeE9LeWV3RDJyYVJhdDNx?= =?utf-8?B?ZjhDZE5NMCszbzhGMHFqaGtLTEhLRTIwMWNzeSsyclhpV1g0bm9PRE1RVWhn?= =?utf-8?B?T093QllicnVxMTN4cDRlUWQzOHFLOG8vOU5MdStQSklYU3dVLzh5eXVnbE4v?= =?utf-8?B?MUtJaGZqL2tJRFczVjF1RUtTdUw3cXhiUUpiM1NzOVZpTjVsaFZKQT09?= X-OriginatorOrg: efficios.com X-MS-Exchange-CrossTenant-Network-Message-Id: 047f83e5-9b4e-4a97-e83a-08deaca5eb35 X-MS-Exchange-CrossTenant-AuthSource: YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 May 2026 02:02:55.1039 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4f278736-4ab6-415c-957e-1f55336bd31e X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: qOHaHn5twFyzix1GOQYlPadge1TBCzSaeO6UnoAglDS6nQbSb31vkI4ayXjnsT1s87Qglp9MY5tTTx78Akavtg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: YQBPR0101MB9151 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 4/28/26 12:19 PM, Tom Tromey wrote: >>>>>> "Simon" == Simon Marchi writes: > > Simon> Move the data currently stored in an inferior registry directly into > Simon> rocm_solib_ops. This changes the storage of this data from "per > Simon> inferior" to "per program-space", but it should be equivalent, since > Simon> there is usually a 1:1 mapping between those two. The only time there > Simon> isn't a 1:1 mapping is during a vfork, before the exec/exit, but no ROCm > Simon> activity happens during that slice of time. > > Worth noting maybe that solib stuff is already per program space so this > probably is more correct in some pedantic way anyway. That's right. > Simon> The rocm_solib_ops constructor has to take an inferior as a parameter, > Simon> rather than a program_space, because of the fd cache. > > I wonder if this could also use the program space. rocm_solib_fd_cache::open calls target_fileio_open, which requires an inferior. If rocm_solib_ops took a program space instead of an inferior, we would probably call find_inferior_for_program_space in rocm_solib_fd_cache::open to get back to an inferior. Might as well keep it inferior all the way. Simon