From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id L7pjE/9A/WnLZiAAWB0awg (envelope-from ) for ; Thu, 07 May 2026 21:48:47 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=efficios.com header.i=@efficios.com header.a=rsa-sha256 header.s=selector1 header.b=EUVgmtlA; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 3920E1E0BA; Thu, 07 May 2026 21:48:47 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 400E61E093 for ; Thu, 07 May 2026 21:48:46 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C129C4BA2E1A for ; Fri, 8 May 2026 01:48:44 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C129C4BA2E1A Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=efficios.com header.i=@efficios.com header.a=rsa-sha256 header.s=selector1 header.b=EUVgmtlA Received: from YT6PR01CU002.outbound.protection.outlook.com (mail-canadacentralazlp170120003.outbound.protection.outlook.com [IPv6:2a01:111:f403:c103::3]) by sourceware.org (Postfix) with ESMTPS id 444D14BA540B for ; Fri, 8 May 2026 01:48:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 444D14BA540B Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=efficios.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=efficios.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 444D14BA540B Authentication-Results: sourceware.org; arc=pass smtp.remote-ip=2a01:111:f403:c103::3 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1778204898; cv=pass; b=Qrp5NZVoQSvGGES2RlCHVQSmIMkCeS/ik1XWAwQD6lcgiUosrBTMvzM3iVylbj5/D4iYCqK1MEVVLbxD2eWyQwvjqvyQedaVpT4TM095sOwg5hmFM2lN8h1toFsxOQZ4SPMmjI/nlrOq5Pyo1HG5pZr9SxaAXDwb3ck58lsrDgA= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1778204898; c=relaxed/simple; bh=p2xksDandLEyKE49GtPxPeawA2zmquH9q7KGn6winT4=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=Z7oRB7HizYzd6otbMfk0nMR4Gr1Rcyqqn04YHt31emAhqL0l1BD9KPG9zO+d5ivVczaT5gmvpHqDPkksOcUfR45KD61JNQgs81dIXV48anQFHUWMMvIXwc1bP+CjfYJpnhVYWu83tk2KmuVSJh24cMZsXXEH98hzITElGYgmlo4= ARC-Authentication-Results: i=2; sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=efficios.com header.i=@efficios.com header.a=rsa-sha256 header.s=selector1 header.b=EUVgmtlA DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 444D14BA540B ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=PIhvQRTi14TzptptlDXuXJLab8vojxfGHTvOQGf0kZ9jD4YJww/NUEySLdU7V84POGuFzrfR+lRe9JY+t+VvAfdsaVXTa5lqivkKNBMFudKIfOmo0x84k9oVtnWslw+skW6eVt2PEUq0xONA6Up8UCDaaA6LcokbIZFbuf4CAlWgKRi39WbqyrPkpByJva0BxL6ues87K5O3XaBR8uqgg6ZhSDv2O46oFGwWVFe2Qy9ZYtFsNswKpXrm7W0551m0NbRIIPgAlfoF8U8KWaS3j68eTPtOMgVBY3P8c8mJN6PLhC0xx0ryH5ZHao7XLhMqMRe5ydcuKRG0GpiSdApVMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=op/1pgt3fc8pGxbfZ4vZn6wNrUxqsN5g2u16otp6Buk=; b=ssmgXMJhIBvl+YL2bl/GqPThnpXUddkzEbhQ9JMVzi/hbAT7cuG4M8BE0a/c7EOsVYKKUAyvqzHBBST9NFahXKZXfV8gMd6oe19z6FfJNB/mHGgwbp0zNoMXkSlOTbLxNovutiMvh5jXSEayx+OnjWWUhhYPwQctetdMWN0DWFZSluhQLUDUQaz6Nw8IimWrazWvyQX/bw2QSLj67eExTOYjwIuE0lBZBrhY72pEpPP7b/ot6w/n2b8GW4F2v75DZboDew8Ch173jQ3q5BOI/8NyMYW9Baavn7KbANj8uzSmQjmkKWxRa8ATeqhDt0bhsI2NifaZQ3dVnb+zKNTjFw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=efficios.com; dmarc=pass action=none header.from=efficios.com; dkim=pass header.d=efficios.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficios.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=op/1pgt3fc8pGxbfZ4vZn6wNrUxqsN5g2u16otp6Buk=; b=EUVgmtlASRlyvOY5V5GgGToAWf6qvk2xUv5GFfYJahxV/FVAQB2eF/qKubqxEqvEtCy56rBJ1NuxvMShbpzJR+481Z8sfIg85qgCWPuw4s9GKzPfkADZoTEKQh1cm7PIj2lr3t5ayRGI807hnEjX2d6WxgguQ6cQ/IqWI+kVWYdHrafNebaoRekD7Wie1Jzk4A91e7uTDviJ+nNz2NS8yVHr8Md8uj0Gc+/65Bfm90QftQKj5LJ43gUWLrsIIes20EOIbrSCK0tB1myqLZ22JgeVUuYR0i08WaPYW3dWiHrdVgr2dDb++aYpDFssqo69KPQCBRg++nvPPkggqPD/Ng== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=efficios.com; Received: from YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:2c::6) by YT3PR01MB9737.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:89::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9891.15; Fri, 8 May 2026 01:48:13 +0000 Received: from YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM ([fe80::bbfa:179f:fdc8:b15d]) by YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM ([fe80::bbfa:179f:fdc8:b15d%3]) with mapi id 15.20.9891.017; Fri, 8 May 2026 01:48:13 +0000 Message-ID: Date: Thu, 7 May 2026 21:48:11 -0400 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/11] gdb/solib-rocm: pass reference to cache to rocm_code_object_stream_file To: Lancelot SIX Cc: gdb-patches@sourceware.org References: <20251209193610.296085-4-simon.marchi@efficios.com> Content-Language: fr From: Simon Marchi In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: YQBPR01CA0038.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:2::10) To YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:2c::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: YQXPR01MB5418:EE_|YT3PR01MB9737:EE_ X-MS-Office365-Filtering-Correlation-Id: f5f38e7b-2aab-4b57-83bf-08deaca3ddbc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|366016|376014|22082099003|56012099003|18002099003; X-Microsoft-Antispam-Message-Info: 9ZdLwElZ/jyT+xvhZJQgYIU8Ih/4J44He4A2DZkRE2Xtk2nQ6eWPCuFMHdHIapXUFe8H1iZUXb4PWQdOXL26fxoebTN9iPwbNb7rTLxDnL1bKna4mjzgKADqAF3DO8jBx9CSJiBHohgDV+ETNmV8TW/5oF7h4Idg0Uj3onme2tHN6v0NSIwdEI2uRoh6Nvg28XS2H2k5Z+uerXaEUzf2fNaCMY9/FvS3hFiiXy3NSK5l7lyL+SFP/at/4Rg5kaQx56y+hKL8MIzoIuNcSsIEs+6qGAqKJ6eTA3Yu33iz0YdTjCZHdiahxGFuR0b7T3RXm5j7ZTS8oVFtvLiCobodwsN11wb5GG9OCeu9V+r1WdA2pRne7K2T/3sf/w74G6YyduyCR3oaGTWwHANRdA8jLkfq7JEyY16SClqbwTFU5GUo+5iFTunWx6I+gCPjnzfV9iDWRSXKMX0bw/pS43FYJWW83Lz1LXZW3sU1C666wcK/9yIQvBg7qmVy4avw1LQAWwRimkyyon0kFsvDIZrwhYm2SEyNJHfmB2zdoZf/P54JB1DnU/TJSEgQzLcvotqrhn/bDERx2g3Zs8xyPqIK3V3g7Ir7cdOcI3lLZXr8ki4+G7uKDK/tEvv6MPxc9KnwL9oGGByY3TQS7IXWovMCrttODoB+e+vtcMsu3SWKtwEnh48mpur8obpB/bw52VQy X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(376014)(22082099003)(56012099003)(18002099003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cHJTNnExemVybFh0S1grdDZwMkI5Q0Y0eXhYa3I3OWREeHpDSlRRbDVMVWFC?= =?utf-8?B?MjB0TW5vdzlCNk02UzlJRldtV1NBRzFzT1BqVEs0WUJFczdickdXem80V1NN?= =?utf-8?B?bmFETVhDRkYwTHB4WERZdTAydkFMNGdjZ0sxdmk1UGNHUTRaNmNnNmU2THJn?= =?utf-8?B?NnMvdjBneURpQlJjQ1BpRktVSnhwQnNhY1dlNnpweUh6KzlZL3QxUVpaWGpK?= =?utf-8?B?YVpoTWE2R0FSOW0rS3RhbGd1cUpraFRCMmYxQXo3WGN5dEpEcCt5N1YrNjBU?= =?utf-8?B?d2JFZWVXM3BDUzRiMzF3WFF6ZERwRmtSSnU1eElJWlBLd1pkWXFUb1Mrc21S?= =?utf-8?B?Z0FaOWlvYzVHY2NkWFBhbTMyL0MrRjdsN1FQS25XYWtENFkwdXFpY3J2dHZz?= =?utf-8?B?UHlEMGR6MGlOcDAxenMrNDFKU0tQYXZEUFQ1M3dDQVpUMHhaWWc1R0M2ZHpp?= =?utf-8?B?UnA3S3RVRlV5MTVTd2tIbzJGdlJUQUJyL1ZRQTc4OExwTHRIVzdCUHdFU2pX?= =?utf-8?B?dEpGL08vWStxK2djRlB4ODljWDdla1d1SmVXbVluT0lSSjROK3ErcnlRRUdM?= =?utf-8?B?ZW9pU2VIMURuTkkvcExrWmw4WElMS0dJOVV0SnpjOW5aQ0FCek93NWpQTENO?= =?utf-8?B?UHkwNWswWVhYWnpBU0tmNFdUZzFaYlZycTZ5Y2Npd1V1blpXS1JucHlwR25q?= =?utf-8?B?anUxZGMxUDgrcmVIeVgxMmY5a2htWEtLWnE2eVZCRTF4b3hZYTk1Z1BmcTYy?= =?utf-8?B?cTJaVm1mMks3Snh3NVZVNW51dnRmak1VUXluSlZuVDhicGxEaFdhNS9LY2Ra?= =?utf-8?B?dkNLbGg4NG96MnA2cUJaSk1WSUcvNldwUDJHMXBkS3pGaUMvYmFBczJiOVIr?= =?utf-8?B?QmN5V0NaUmpVN0hWRndLYnhHcVJMNXBMRUhpLzdjSitGQm0zdWk0TE41RkhF?= =?utf-8?B?Z01nZXhDZTZQWlIrWTluek9xMm5DZ1hkSnE0dlc0TEYvTFpwdnJoU1MxNVFW?= =?utf-8?B?Ky9GaUpFcW1jQ092TEdWMGVmcnZaSWpqeHdYOFB2dkJ1VXA2NFVScmJURjVS?= =?utf-8?B?b3Q4NkE3bzIwTUwxSmg0VjFiNW9jZGZxQW5WSXo1UVJtSHNKSmR4QUVYTFNr?= =?utf-8?B?VHM0ZFBVWEwzdk1EV0Q2ektEWnZvenBsN25sdm1tVXphOUFyc2RnWXgyYmo1?= =?utf-8?B?VGZQNG85V0xPaEdpdWI1c3hqeTFCbWdCSHZDV1kyK0JiUWgweTZMc2JGSFBv?= =?utf-8?B?bjFqUkpMTkQ2QVJBNHRJRWtPR2FIb28yRmxYalBhTVpxMDRvMlFCNnlkcGly?= =?utf-8?B?ZTZSZFBFYWJKSkxEcFlOSVJvcVVSU2hORHh5dGczaWphUEc4dnpwWVBDZmNz?= =?utf-8?B?dUxKL2JEckFZaTdOZnFqQ0E3U0QwNmRIL1pCaWswZjNoSUdhRGMwT3JmME55?= =?utf-8?B?MWFUSTBjYTB2RjVpZ0d2dWJxVUJGOGgySERqMzRobmRacS9JMjk0WjQrNTJG?= =?utf-8?B?V3BvcEdZUThGWjAwWmdKTXJVR3UzMlpjSmsvbFNJM2c0eWszZlc0T3BnSlpD?= =?utf-8?B?Y1VqU3I1Y1BZdU1VTURvMHpIeFpWZ3lsU2RPcWtZQmxRUThyNHJlWGI5YUdl?= =?utf-8?B?K3lGWG1WUkk3a1o1Z1lheS9DYUg3bmNqMTBHTW1JMDMrN0xzc0FRZkFpamxR?= =?utf-8?B?bG5PVWhDUGwwSjBjcjk2Uy84V1plaHFTSXNMYlhBaE5yTGxxREROV2xJTnQ3?= =?utf-8?B?TkVOQzc3ZGg1VWN1SUV4amFjbWtqN3Qyd3J3SnZSbE9JV1dyTzhCdGFJbzY5?= =?utf-8?B?NEo2T0M5Wmw5elBNN0ZYZWJmeHNwOVJnbGFkM21TM1lCMnFrSnNmaDRidStn?= =?utf-8?B?VWxEVzVjODJSaXMvSytNRVFGNEdOb2c4V21ub3NsZUR0RzJqS1VQU0V5RWxP?= =?utf-8?B?VVNVaVJNZDJGQ0xqN1NqYXNXVDRnb09ablB3ODBKUkNjQU1LV1BHa2hQYVJo?= =?utf-8?B?R0owYmFqQTVKMWd6Mll0czNZOHh6Z0M2Ri82SGU3OS83RkJzaGFodWFFS1kw?= =?utf-8?B?bEZiTS9EdHh2MXlRY1NHSnhYdk5LSVAySURYVTBhSVVYZFd4NUVSbHdOSG51?= =?utf-8?B?U3hKSzZhRmFtc2FGQlNwUEh1Nm02UmJRV3NtMG96VUh4Vm9pOUY0OE15QXlX?= =?utf-8?B?cnU0YVpsYzJNUDNsZFpRckhIbWdFa1RmOW1WUnhCeSsvbXZDOWJPZTZjRVRS?= =?utf-8?B?UlhGRjRmRHVEd1R4TFFQL2NManZBWEpua09pTEJDUDhIaEVPeUpFQVRZM3BV?= =?utf-8?B?UWw5V0Z4aVdDeFI4dUxXZUdSaElMUUpldU9wbm1YT0xqOHBjZE4zUT09?= X-OriginatorOrg: efficios.com X-MS-Exchange-CrossTenant-Network-Message-Id: f5f38e7b-2aab-4b57-83bf-08deaca3ddbc X-MS-Exchange-CrossTenant-AuthSource: YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 May 2026 01:48:13.4650 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4f278736-4ab6-415c-957e-1f55336bd31e X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: lgs6+gE0Vl6/76dcm5t9l0SzIt0oIjEj3kvViFSwMuNPfSt7rQOXssDyisBq4UA0duCrUZ0iIf0ay7kc5eaGUA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: YT3PR01MB9737 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 5/7/26 2:20 PM, Lancelot SIX wrote: > On Tue, Dec 09, 2025 at 02:32:07PM -0500, Simon Marchi wrote: >> ~rocm_code_object_stream_file obtains the fd cache to call "close" on >> using its m_inf field, obtaining the per-inferior info using >> get_solib_info. A patch later in this series moves the fd cache from >> the per-inferior registry to the rocm_solib_ops directly. This implies >> that we will need a new way to get a reference to the fd_cache owning >> the fd, as it won't be easy to get it from the inferior anymore. >> >> To achieve this, update rocm_code_object_stream_file to keep a reference >> to the fd cache directly (because the rocm_code_object_stream is not >> meant to be copied nor moved, make the field a reference). The inferior >> parameter and field are not needed anymore. >> >> Change-Id: Ia10f8f125840274e51e188cafcb7384fdff92240 >> --- >> gdb/solib-rocm.c | 19 +++++++++---------- >> 1 file changed, 9 insertions(+), 10 deletions(-) >> >> diff --git a/gdb/solib-rocm.c b/gdb/solib-rocm.c >> index a9573f8eefde..bde34bafd8b1 100644 >> --- a/gdb/solib-rocm.c >> +++ b/gdb/solib-rocm.c >> @@ -360,8 +360,8 @@ struct rocm_code_object_stream_file final : rocm_code_object_stream >> { >> DISABLE_COPY_AND_ASSIGN (rocm_code_object_stream_file); >> >> - rocm_code_object_stream_file (inferior *inf, int fd, ULONGEST offset, >> - ULONGEST size); >> + rocm_code_object_stream_file (rocm_solib_fd_cache &fd_cache, int fd, >> + ULONGEST offset, ULONGEST size); > > Just noting that this does not apply anymore, just need to change > "int fd" to "target_fd fd". Thanks, I saw that while rebasing. > > Other than that, this looks good to me. > > Thanks. > > Approved-by: Lancelot Six (amdgpu) Ack, thanks. Simon