From: Tom de Vries <tdevries@suse.de>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 2/3] [gdb/testsuite] Kill left-over process in gdb.base/add-symbol-file-attach.exp
Date: Mon, 24 Feb 2025 19:43:19 +0100 [thread overview]
Message-ID: <be4696bc-2777-4b30-99b3-8c02b2162944@suse.de> (raw)
In-Reply-To: <87eczn5icx.fsf@tromey.com>
On 2/24/25 19:05, Tom Tromey wrote:
>>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
>
>>> Should this really yield unsupported, though, and not a fail?
>
> Tom> AFAIU, the only thing that FAIL should be used for, is if gdb is
> Tom> behaving incorrectly. In this case, gdb is not involved, this is just
> Tom> expact spawning a process for gdb to attach to.
>
> Yeah, that makes sense. But I think it also makes sense to
> differentiate between "cannot run because you don't have a C++ compiler"
> and "spawn failed somehow but should not have".
>
> The former is an expected thing -- you didn't want to test C++ or Ada or
> whatever.
>
> The latter is some kind of error.
True.
I don't think we have anything to express this currently.
One could consider ERROR, but IMO that's reserved for a problem in the
test suite. In this case, that may not necessarily be the case, the
system may just have run out of enough memory to spawn a process.
I've suggested before to use UNSUPPORTED/UNTESTED for the difference
between:
- gdb doesn't supported it (say gdb is compiled with --disable-tui),
and
- the environment doesn't support it,
and you could say that this is an instance of the latter.
In another case, I've suggested to use "UNSUPPORTED: <standard message>:
$msg" for particular kinds of unsupported, like the case where a
test-case needs specific support for an architecture, like some register
or dwarf register number.
Thanks,
- Tom
next prev parent reply other threads:[~2025-02-24 18:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-17 16:36 [PATCH 0/3] [gdb/testsuite] Clean up left-over processes Tom de Vries
2025-02-17 16:36 ` [PATCH 1/3] [gdb/testsuite] Don't start gdb in gdb.base/gstack.exp Tom de Vries
2025-02-17 17:20 ` Keith Seitz
2025-02-18 7:59 ` Tom de Vries
2025-02-17 16:36 ` [PATCH 2/3] [gdb/testsuite] Kill left-over process in gdb.base/add-symbol-file-attach.exp Tom de Vries
2025-02-24 17:26 ` Tom Tromey
2025-02-24 17:57 ` Tom de Vries
2025-02-24 18:05 ` Tom Tromey
2025-02-24 18:43 ` Tom de Vries [this message]
2025-02-17 16:36 ` [PATCH 3/3] [gdb/testsuite] Exit left-over gdb in gdb.mi/mi-break.exp Tom de Vries
2025-02-24 17:28 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=be4696bc-2777-4b30-99b3-8c02b2162944@suse.de \
--to=tdevries@suse.de \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox