From: Tom de Vries <tdevries@suse.de>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 2/3] [gdb/testsuite] Kill left-over process in gdb.base/add-symbol-file-attach.exp
Date: Mon, 24 Feb 2025 18:57:35 +0100 [thread overview]
Message-ID: <91ab3691-d4a7-4909-9b2c-6d563bb1dad8@suse.de> (raw)
In-Reply-To: <87mseb5k5w.fsf@tromey.com>
On 2/24/25 18:26, Tom Tromey wrote:
>>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
>
> Tom> +require {valid_spawn_id $test_spawn_id}
> Tom> +at_finish_kill_wait $test_spawn_id
>
> Should this really yield unsupported, though, and not a fail?
>
AFAIU, the only thing that FAIL should be used for, is if gdb is
behaving incorrectly. In this case, gdb is not involved, this is just
expact spawning a process for gdb to attach to.
> Also I was wondering if at_finish_kill_wait should just be implicit in
> the spawn.
I thought about that as well, but I think there are cases were spawned
processes are killed through other means.
Maybe we can do this by default, and then add a parameter to disable
that to deal with those cases.
Thanks,
- Tom
next prev parent reply other threads:[~2025-02-24 17:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-17 16:36 [PATCH 0/3] [gdb/testsuite] Clean up left-over processes Tom de Vries
2025-02-17 16:36 ` [PATCH 1/3] [gdb/testsuite] Don't start gdb in gdb.base/gstack.exp Tom de Vries
2025-02-17 17:20 ` Keith Seitz
2025-02-18 7:59 ` Tom de Vries
2025-02-17 16:36 ` [PATCH 2/3] [gdb/testsuite] Kill left-over process in gdb.base/add-symbol-file-attach.exp Tom de Vries
2025-02-24 17:26 ` Tom Tromey
2025-02-24 17:57 ` Tom de Vries [this message]
2025-02-24 18:05 ` Tom Tromey
2025-02-24 18:43 ` Tom de Vries
2025-02-17 16:36 ` [PATCH 3/3] [gdb/testsuite] Exit left-over gdb in gdb.mi/mi-break.exp Tom de Vries
2025-02-24 17:28 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=91ab3691-d4a7-4909-9b2c-6d563bb1dad8@suse.de \
--to=tdevries@suse.de \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox